Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ASoC: mediatek: mt8188-afe-pcm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Trevor Wu <trevor.wu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-112-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
bb5ba5fe 718041d4

+2 -4
+2 -4
sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
··· 3323 3323 return ret; 3324 3324 } 3325 3325 3326 - static int mt8188_afe_pcm_dev_remove(struct platform_device *pdev) 3326 + static void mt8188_afe_pcm_dev_remove(struct platform_device *pdev) 3327 3327 { 3328 3328 snd_soc_unregister_component(&pdev->dev); 3329 - 3330 - return 0; 3331 3329 } 3332 3330 3333 3331 static const struct of_device_id mt8188_afe_pcm_dt_match[] = { ··· 3346 3348 .pm = &mt8188_afe_pm_ops, 3347 3349 }, 3348 3350 .probe = mt8188_afe_pcm_dev_probe, 3349 - .remove = mt8188_afe_pcm_dev_remove, 3351 + .remove_new = mt8188_afe_pcm_dev_remove, 3350 3352 }; 3351 3353 3352 3354 module_platform_driver(mt8188_afe_pcm_driver);