Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

interconnect: qcom/msm8974: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20231031222851.3126434-17-u.kleine-koenig@pengutronix.de
Signed-off-by: Georgi Djakov <djakov@kernel.org>

authored by

Uwe Kleine-König and committed by
Georgi Djakov
9d960441 653959e3

+2 -4
+2 -4
drivers/interconnect/qcom/msm8974.c
··· 740 740 return ret; 741 741 } 742 742 743 - static int msm8974_icc_remove(struct platform_device *pdev) 743 + static void msm8974_icc_remove(struct platform_device *pdev) 744 744 { 745 745 struct msm8974_icc_provider *qp = platform_get_drvdata(pdev); 746 746 747 747 icc_provider_deregister(&qp->provider); 748 748 icc_nodes_remove(&qp->provider); 749 749 clk_bulk_disable_unprepare(qp->num_clks, qp->bus_clks); 750 - 751 - return 0; 752 750 } 753 751 754 752 static const struct of_device_id msm8974_noc_of_match[] = { ··· 762 764 763 765 static struct platform_driver msm8974_noc_driver = { 764 766 .probe = msm8974_icc_probe, 765 - .remove = msm8974_icc_remove, 767 + .remove_new = msm8974_icc_remove, 766 768 .driver = { 767 769 .name = "qnoc-msm8974", 768 770 .of_match_table = msm8974_noc_of_match,