Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: staging: media: davinci_vpfe: constify vb2_ops structures

These vb2_ops structures are only stored in the ops field of a
vb2_queue structure, which is declared as const. Thus the vb2_ops
structures themselves can be const.

Done with the help of Coccinelle.

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct vb2_ops i@p = { ... };

@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

authored by

Julia Lawall and committed by
Mauro Carvalho Chehab
22f43888 c236323d

+1 -1
+1 -1
drivers/staging/media/davinci_vpfe/vpfe_video.c
··· 1304 1304 list_del_init(&buf->list); 1305 1305 } 1306 1306 1307 - static struct vb2_ops video_qops = { 1307 + static const struct vb2_ops video_qops = { 1308 1308 .queue_setup = vpfe_buffer_queue_setup, 1309 1309 .buf_init = vpfe_buffer_init, 1310 1310 .buf_prepare = vpfe_buffer_prepare,