Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: davinci: vpbe: constify vb2_ops structures

These vb2_ops structures are only stored in the ops field of a
vb2_queue structure, which is declared as const. Thus the vb2_ops
structures themselves can be const.

Done with the help of Coccinelle.

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct vb2_ops i@p = { ... };

@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

authored by

Julia Lawall and committed by
Mauro Carvalho Chehab
c236323d aa7d01fd

+1 -1
+1 -1
drivers/media/platform/davinci/vpbe_display.c
··· 355 355 spin_unlock_irqrestore(&disp->dma_queue_lock, flags); 356 356 } 357 357 358 - static struct vb2_ops video_qops = { 358 + static const struct vb2_ops video_qops = { 359 359 .queue_setup = vpbe_buffer_queue_setup, 360 360 .wait_prepare = vb2_ops_wait_prepare, 361 361 .wait_finish = vb2_ops_wait_finish,