Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

objtool: Skip unreachable warnings for 'alt' instructions

When a whitelisted function uses one of the ALTERNATIVE macros, it
produces false positive warnings like:

arch/x86/kvm/vmx.o: warning: objtool: .altinstr_replacement+0x0: unreachable instruction
arch/x86/kvm/svm.o: warning: objtool: .altinstr_replacement+0x6e: unreachable instruction

There's no easy way to whitelist alternative instructions, so instead
just skip any 'unreachable' warnings associated with them.

Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/a5d0a8c60155f03b36a31fac871e12cf75f35fd0.1501188854.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>

authored by

Josh Poimboeuf and committed by
Ingo Molnar
0e2bb2bc 649ea4d5

+6 -1
+6 -1
tools/objtool/check.c
··· 1746 1746 /* 1747 1747 * Ignore any unused exceptions. This can happen when a whitelisted 1748 1748 * function has an exception table entry. 1749 + * 1750 + * Also ignore alternative replacement instructions. This can happen 1751 + * when a whitelisted function uses one of the ALTERNATIVE macros. 1749 1752 */ 1750 - if (!strcmp(insn->sec->name, ".fixup")) 1753 + if (!strcmp(insn->sec->name, ".fixup") || 1754 + !strcmp(insn->sec->name, ".altinstr_replacement") || 1755 + !strcmp(insn->sec->name, ".altinstr_aux")) 1751 1756 return true; 1752 1757 1753 1758 /*