Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ASoC: Intel: sst-mfld-platform-pcm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-93-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
0d31e8ad ab443489

+2 -3
+2 -3
sound/soc/intel/atom/sst-mfld-platform-pcm.c
··· 741 741 return ret; 742 742 } 743 743 744 - static int sst_platform_remove(struct platform_device *pdev) 744 + static void sst_platform_remove(struct platform_device *pdev) 745 745 { 746 746 dev_dbg(&pdev->dev, "sst_platform_remove success\n"); 747 - return 0; 748 747 } 749 748 750 749 #ifdef CONFIG_PM_SLEEP ··· 812 813 .pm = &sst_platform_pm, 813 814 }, 814 815 .probe = sst_platform_probe, 815 - .remove = sst_platform_remove, 816 + .remove_new = sst_platform_remove, 816 817 }; 817 818 818 819 module_platform_driver(sst_platform_driver);