Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ASoC: img: pistachio-internal-dac: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-92-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
ab443489 4e894b2e

+2 -4
+2 -4
sound/soc/img/pistachio-internal-dac.c
··· 215 215 return ret; 216 216 } 217 217 218 - static int pistachio_internal_dac_remove(struct platform_device *pdev) 218 + static void pistachio_internal_dac_remove(struct platform_device *pdev) 219 219 { 220 220 struct pistachio_internal_dac *dac = dev_get_drvdata(&pdev->dev); 221 221 222 222 pm_runtime_disable(&pdev->dev); 223 223 pistachio_internal_dac_pwr_off(dac); 224 224 regulator_disable(dac->supply); 225 - 226 - return 0; 227 225 } 228 226 229 227 #ifdef CONFIG_PM ··· 271 273 .pm = &pistachio_internal_dac_pm_ops 272 274 }, 273 275 .probe = pistachio_internal_dac_probe, 274 - .remove = pistachio_internal_dac_remove 276 + .remove_new = pistachio_internal_dac_remove 275 277 }; 276 278 module_platform_driver(pistachio_internal_dac_plat_driver); 277 279