Signed-off-by: Seongmin Lee git@boltless.me
appview/db/comments.go
This file has not been changed.
appview/db/issues.go
This file has not been changed.
appview/db/reference.go
This file has not been changed.
appview/ingester.go
This file has not been changed.
appview/issues/issues.go
This file has not been changed.
appview/models/issue.go
This file has not been changed.
appview/notify/db/db.go
This file has not been changed.
appview/notify/merged_notifier.go
This file has not been changed.
appview/notify/notifier.go
This file has not been changed.
appview/notify/posthog/notifier.go
This file has not been changed.
appview/pages/pages.go
This file has not been changed.
appview/pages/templates/repo/issues/fragments/commentList.html
This file has not been changed.
appview/pages/templates/repo/issues/fragments/issueCommentHeader.html
This file has not been changed.
appview/state/state.go
This file has not been changed.
appview/validator/issue.go
This file has not been changed.
History
8 rounds
1 comment
1 commit
expand
collapse
IssueComment to Comment
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 failed, 1/3 success
expand
collapse
merge conflicts detected
expand
collapse
- appview/notify/db/db.go:260
- appview/notify/merged_notifier.go:81
- appview/notify/notifier.go:22
- appview/pulls/opengraph.go:277
expand 0 comments
1 commit
expand
collapse
IssueComment to Comment
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 failed, 1/3 success
expand
collapse
expand 0 comments
1 commit
expand
collapse
IssueComment to Comment
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
1 commit
expand
collapse
IssueComment to Comment
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
1 commit
expand
collapse
IssueComment to Comment
Signed-off-by: Seongmin Lee <git@boltless.me>
1/3 failed, 2/3 success
expand
collapse
expand 0 comments
1 commit
expand
collapse
IssueComment to Comment
Signed-off-by: Seongmin Lee <git@boltless.me>
1/3 failed, 2/3 success
expand
collapse
expand 0 comments
1 commit
expand
collapse
IssueComment to Comment
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 1 comment
1 commit
expand
collapse
IssueComment to Comment
Signed-off-by: Seongmin Lee <git@boltless.me>
imo: we should still continue to ingest
sh.tangled.issue.comment(and pull comments), but just try to convert to the regular lexicon. this would only be used for backfill purposes, newer appviews should ideally not create the old NSID anymore.the way i see it, the new lexicon is just an alias for the old ones, so the ingesters should be backwards compatible.
i will do a deeper dive into the code itself shortly.