tangled.org
Signed-off-by: Seongmin Lee git@boltless.me
Monorepo for Tangled
tangled.org
appview: replace PullComment to Comment
#865
open
opened by
boltless.me
targeting
master
from
sl/wnrvrwyvrlzo
STACK 4
expand 1 commit
hide 1 commit
appview: replace
PullComment to Comment
Signed-off-by: Seongmin Lee <git@boltless.me>
expand 1 commit
hide 1 commit
appview: replace
PullComment to Comment
Signed-off-by: Seongmin Lee <git@boltless.me>
I should've been more precise about my expression. Existing comments won't be dropped as they are stored in issue_comments and pull_comments table (I'm just dropping legacy table with same name there), but yeah this PR itself doesn't include the backward compatibility layer yet so old comments won't be rendered.
Honestly this PR hasn't been updated since you two suggested to just ingest old records. I'll push more commits on top of this stack.
As a side note: I'd suggest to not publish the new sh.tangled.comment lexicon yet.
This unified comment record can be used for PR review comments and it might make us to modify the schema again. I think it would be safest to publish this when PR redesign discussion is finished.
expand 1 commit
hide 1 commit
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
no conflicts, ready to merge
Labels
None yet.
assignee
None yet.
Participants
2
Referenced by
here will this delete all comments made on tangled thus far? don't think this is the right approach if so.