tangled.org
Signed-off-by: Seongmin Lee git@boltless.me
+4
-3
appview/db/comments.go
+4
-3
appview/db/comments.go
···
11
12
"github.com/bluesky-social/indigo/atproto/syntax"
13
"tangled.org/core/appview/models"
14
)
15
16
func PutComment(tx *sql.Tx, c *models.Comment) error {
···
62
return nil
63
}
64
65
-
func DeleteComments(e Execer, filters ...filter) error {
66
var conditions []string
67
var args []any
68
for _, filter := range filters {
···
81
return err
82
}
83
84
-
func GetComments(e Execer, filters ...filter) ([]models.Comment, error) {
85
commentMap := make(map[string]*models.Comment)
86
87
var conditions []string
···
174
175
// collect references from each comments
176
commentAts := slices.Collect(maps.Keys(commentMap))
177
-
allReferencs, err := GetReferencesAll(e, FilterIn("from_at", commentAts))
178
if err != nil {
179
return nil, fmt.Errorf("failed to query reference_links: %w", err)
180
}
···
11
12
"github.com/bluesky-social/indigo/atproto/syntax"
13
"tangled.org/core/appview/models"
14
+
"tangled.org/core/orm"
15
)
16
17
func PutComment(tx *sql.Tx, c *models.Comment) error {
···
63
return nil
64
}
65
66
+
func DeleteComments(e Execer, filters ...orm.Filter) error {
67
var conditions []string
68
var args []any
69
for _, filter := range filters {
···
82
return err
83
}
84
85
+
func GetComments(e Execer, filters ...orm.Filter) ([]models.Comment, error) {
86
commentMap := make(map[string]*models.Comment)
87
88
var conditions []string
···
175
176
// collect references from each comments
177
commentAts := slices.Collect(maps.Keys(commentMap))
178
+
allReferencs, err := GetReferencesAll(e, orm.FilterIn("from_at", commentAts))
179
if err != nil {
180
return nil, fmt.Errorf("failed to query reference_links: %w", err)
181
}
appview/db/db.go
appview/db/db.go
This patch was likely rebased, as context lines do not match.
appview/db/pulls.go
appview/db/pulls.go
This patch was likely rebased, as context lines do not match.
appview/db/reference.go
appview/db/reference.go
This patch was likely rebased, as context lines do not match.
appview/models/comment.go
appview/models/comment.go
This file has not been changed.
appview/models/pull.go
appview/models/pull.go
This file has not been changed.
appview/notify/db/db.go
appview/notify/db/db.go
This patch was likely rebased, as context lines do not match.
appview/notify/merged_notifier.go
appview/notify/merged_notifier.go
This file has not been changed.
appview/notify/notifier.go
appview/notify/notifier.go
This file has not been changed.
appview/notify/posthog/notifier.go
appview/notify/posthog/notifier.go
This file has not been changed.
appview/pages/templates/repo/pulls/pull.html
appview/pages/templates/repo/pulls/pull.html
This file has not been changed.
appview/pulls/opengraph.go
appview/pulls/opengraph.go
This patch was likely rebased, as context lines do not match.
appview/pulls/pulls.go
appview/pulls/pulls.go
This patch was likely rebased, as context lines do not match.
History
8 rounds
4 comments
boltless.me
submitted
#7
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 timeout, 1/3 success
expand
collapse
merge conflicts detected
expand
collapse
expand
collapse
- appview/notify/db/db.go:260
- appview/notify/merged_notifier.go:81
- appview/notify/notifier.go:22
- appview/pulls/opengraph.go:277
expand 0 comments
boltless.me
submitted
#6
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 failed, 1/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#5
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#4
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 1 comment
boltless.me
submitted
#3
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
1/3 failed, 2/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#2
1 commit
expand
collapse
appview: replace
PullComment to Comment
Including db migration to migrate `issue_comments` and `pull_comments`
to unified `comments` table.
Signed-off-by: Seongmin Lee <git@boltless.me>
1/3 failed, 2/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#1
1 commit
expand
collapse
appview: replace
PullComment to Comment
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 3 comments
I should've been more precise about my expression. Existing comments won't be dropped as they are stored in issue_comments and pull_comments table (I'm just dropping legacy table with same name there), but yeah this PR itself doesn't include the backward compatibility layer yet so old comments won't be rendered.
Honestly this PR hasn't been updated since you two suggested to just ingest old records. I'll push more commits on top of this stack.
As a side note: I'd suggest to not publish the new sh.tangled.comment lexicon yet.
This unified comment record can be used for PR review comments and it might make us to modify the schema again. I think it would be safest to publish this when PR redesign discussion is finished.
boltless.me
submitted
#0
1 commit
expand
collapse
appview: replace
PullComment to Comment
Signed-off-by: Seongmin Lee <git@boltless.me>
here, the sort order is reversed, it should be
.Before.