tangled.org
Close: #231
Signed-off-by: Seongmin Lee git@boltless.me
appview/repo/archive.go
appview/repo/archive.go
This file has not been changed.
appview/repo/router.go
appview/repo/router.go
This file has not been changed.
appview/state/git_http.go
appview/state/git_http.go
This patch was likely rebased, as context lines do not match.
+17
appview/state/proxy_knot.go
+17
appview/state/proxy_knot.go
···
31
31
32
32
}
33
33
34
+
func (s *State) UploadArchive(w http.ResponseWriter, r *http.Request) {
35
+
user, ok := r.Context().Value("resolvedId").(identity.Identity)
36
+
if !ok {
37
+
http.Error(w, "failed to resolve user", http.StatusInternalServerError)
38
+
return
39
+
}
40
+
repo := r.Context().Value("repo").(*models.Repo)
41
+
42
+
scheme := "https"
43
+
if s.config.Core.Dev {
44
+
scheme = "http"
45
+
}
46
+
47
+
targetURL := fmt.Sprintf("%s://%s/%s/%s/git-upload-archive?%s", scheme, repo.Knot, user.DID, repo.Name, r.URL.RawQuery)
48
+
s.proxyRequest(w, r, targetURL)
49
+
}
50
+
34
51
func (s *State) UploadPack(w http.ResponseWriter, r *http.Request) {
35
52
user, ok := r.Context().Value("resolvedId").(identity.Identity)
36
53
if !ok {
appview/state/router.go
appview/state/router.go
This patch was likely rebased, as context lines do not match.
go.mod
go.mod
This file has not been changed.
go.sum
go.sum
This file has not been changed.
knotserver/archive.go
knotserver/archive.go
This file has not been changed.
knotserver/git/git.go
knotserver/git/git.go
This file has not been changed.
knotserver/router.go
knotserver/router.go
This patch was likely rebased, as context lines do not match.
knotserver/xrpc/repo_archive.go
knotserver/xrpc/repo_archive.go
This file has not been changed.
knotserver/xrpc/xrpc.go
knotserver/xrpc/xrpc.go
This file has not been changed.
lexicons/repo/archive.json
lexicons/repo/archive.json
This file has not been changed.
nix/gomod2nix.toml
nix/gomod2nix.toml
This file has not been changed.
History
7 rounds
2 comments
boltless.me
submitted
#6
2 commits
expand
collapse
appview,knotserver: support immutable nix flakeref link header
This will allow users to directly request archive from the knot without
using xrpc.
Xrpc doesn't fit here because it strips out the http headers which might
include valuable metadata like download filename or immutable link.
- implement archive on knot as `/{owner}/{repo}/archive/{ref}`
endpoint
- appview proxies the request to knot on `/archive` like it is doing for
git http endpoints.
if knot version isn't compatible, it will fallback to legacy xrpc
endpoint.
- rename the `git_http.go` file to generalized `proxy_knot.go` filaname
xrpc method `sh.tangled.repo.archive` will be deprecated in future
added `go-version` depenedency to make version constraints
Close: <https://tangled.org/tangled.org/core/issues/231>
Signed-off-by: Seongmin Lee <git@boltless.me>
lexicons,knotserver: remove
/xrpc/sh.tangled.repo.archive endpoint
replaced by `/{did}/{reponame}/archive/{ref}`. The lexicon definitions
will be removed later.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 1 comment
closed without merging
boltless.me
submitted
#5
2 commits
expand
collapse
appview,knotserver: support immutable nix flakeref link header
This will allow users to directly request archive from the knot without
using xrpc.
Xrpc doesn't fit here because it strips out the http headers which might
include valuable metadata like download filename or immutable link.
- implement archive on knot as `/{owner}/{repo}/archive/{ref}`
endpoint
- appview proxies the request to knot on `/archive` like it is doing for
git http endpoints.
if knot version isn't compatible, it will fallback to legacy xrpc
endpoint.
- rename the `git_http.go` file to generalized `proxy_knot.go` filaname
xrpc method `sh.tangled.repo.archive` will be deprecated in future
added `go-version` depenedency to make version constraints
Close: <https://tangled.org/tangled.org/core/issues/231>
Signed-off-by: Seongmin Lee <git@boltless.me>
lexicons,knotserver: remove
/xrpc/sh.tangled.repo.archive endpoint
replaced by `/{did}/{reponame}/archive/{ref}`. The lexicon definitions
will be removed later.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#4
3 commits
expand
collapse
nix: bump gomod2nix
Signed-off-by: Seongmin Lee <git@boltless.me>
appview,knotserver: support immutable nix flakeref link header
This will allow users to directly request archive from the knot without
using xrpc.
Xrpc doesn't fit here because it strips out the http headers which might
include valuable metadata like download filename or immutable link.
- implement archive on knot as `/{owner}/{repo}/archive/{ref}`
endpoint
- appview proxies the request to knot on `/archive` like it is doing for
git http endpoints.
if knot version isn't compatible, it will fallback to legacy xrpc
endpoint.
- rename the `git_http.go` file to generalized `proxy_knot.go` filaname
xrpc method `sh.tangled.repo.archive` will be deprecated in future
added `go-version` depenedency to make version constraints
Close: <https://tangled.org/tangled.org/core/issues/231>
Signed-off-by: Seongmin Lee <git@boltless.me>
lexicons,knotserver: remove
/xrpc/sh.tangled.repo.archive endpoint
replaced by `/{did}/{reponame}/archive/{ref}`. The lexicon definitions
will be removed later.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#3
3 commits
expand
collapse
nix: bump gomod2nix
Signed-off-by: Seongmin Lee <git@boltless.me>
appview,knotserver: support immutable nix flakeref link header
This will allow users to directly request archive from the knot without
using xrpc.
Xrpc doesn't fit here because it strips out the http headers which might
include valuable metadata like download filename or immutable link.
- implement archive on knot as `/{owner}/{repo}/archive/{ref}`
endpoint
- appview proxies the request to knot on `/archive` like it is doing for
git http endpoints.
if knot version isn't compatible, it will fallback to legacy xrpc
endpoint.
- rename the `git_http.go` file to generalized `proxy_knot.go` filaname
xrpc method `sh.tangled.repo.archive` will be deprecated in future
added `go-version` depenedency to make version constraints
Close: <https://tangled.org/tangled.org/core/issues/231>
Signed-off-by: Seongmin Lee <git@boltless.me>
lexicons,knotserver: remove
sh.tangled.repo.archive
Xrpc is not a good way to implement this as Xrpc clients usually strips
out the response http headers.
The archive should be implemented in raw http endpoint instead like git
https endpoints
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 failed, 1/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#2
3 commits
expand
collapse
appview,knotserver: support knot http endpoint for archive
This will allow users to directly request archive from the knot without
using xrpc.
Xrpc doesn't fit here because it strips out the http headers which might
include valuable metadata like download filename or immutable link.
- remove xrpc method `sh.tangled.repo.archive`
- reimplement archive on knot as `/{owner}/{repo}/archive/{ref}`
endpoint
- appview will just proxy the request to knot on `/archive` like it is
doing for git http endpoints
- rename the `git_http.go` file to generalized `proxy_knot.go` filaname
Signed-off-by: Seongmin Lee <git@boltless.me>
knotserver: support immutable nix flakeref link header
Close: #231
Signed-off-by: Seongmin Lee <git@boltless.me>
lexicons,knotserver: remove
sh.tangled.repo.archive
Xrpc is not a good way to implement this as Xrpc clients usually strips
out the response http headers.
The archive should be implemented in raw http endpoint instead like git
https endpoints
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#1
1 commit
expand
collapse
appview,knotserver: immutable nix flakeref link header
Close: #231
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#0
1 commit
expand
collapse
appview,knotserver: immutable nix flakeref link header
Close: #231
Signed-off-by: Seongmin Lee <git@boltless.me>
closing for https://tangled.org/tangled.org/core/pulls/1001