tangled.org
Close: #231
Signed-off-by: Seongmin Lee git@boltless.me
+41
api/tangled/repoarchive.go
+41
api/tangled/repoarchive.go
···
1
+
// Code generated by cmd/lexgen (see Makefile's lexgen); DO NOT EDIT.
2
+
3
+
package tangled
4
+
5
+
// schema: sh.tangled.repo.archive
6
+
7
+
import (
8
+
"bytes"
9
+
"context"
10
+
11
+
"github.com/bluesky-social/indigo/lex/util"
12
+
)
13
+
14
+
const (
15
+
RepoArchiveNSID = "sh.tangled.repo.archive"
16
+
)
17
+
18
+
// RepoArchive calls the XRPC method "sh.tangled.repo.archive".
19
+
//
20
+
// format: Archive format
21
+
// prefix: Prefix for files in the archive
22
+
// ref: Git reference (branch, tag, or commit SHA)
23
+
// repo: Repository identifier in format 'did:plc:.../repoName'
24
+
func RepoArchive(ctx context.Context, c util.LexClient, format string, prefix string, ref string, repo string) ([]byte, error) {
25
+
buf := new(bytes.Buffer)
26
+
27
+
params := map[string]interface{}{}
28
+
if format != "" {
29
+
params["format"] = format
30
+
}
31
+
if prefix != "" {
32
+
params["prefix"] = prefix
33
+
}
34
+
params["ref"] = ref
35
+
params["repo"] = repo
36
+
if err := c.LexDo(ctx, util.Query, "", "sh.tangled.repo.archive", params, nil, buf); err != nil {
37
+
return nil, err
38
+
}
39
+
40
+
return buf.Bytes(), nil
41
+
}
appview/repo/archive.go
appview/repo/archive.go
This file has not been changed.
appview/repo/router.go
appview/repo/router.go
This file has not been changed.
appview/state/git_http.go
appview/state/git_http.go
This file has not been changed.
+3
-2
appview/state/proxy_knot.go
+3
-2
appview/state/proxy_knot.go
···
65
65
s.proxyRequest(w, r, targetURL)
66
66
}
67
67
68
-
var knotVersionDownloadArchiveConstraint = version.MustConstraints(version.NewConstraint(">= 1.12"))
68
+
var knotVersionDownloadArchiveConstraint = version.MustConstraints(version.NewConstraint(">= 1.12.0-alpha"))
69
69
70
70
func (s *State) DownloadArchive(w http.ResponseWriter, r *http.Request) {
71
71
l := s.logger.With("handler", "DownloadArchive")
···
84
84
scheme = "http"
85
85
}
86
86
87
+
host := fmt.Sprintf("%s://%s", scheme, repo.Knot)
87
88
xrpcc := &indigoxrpc.Client{
88
-
Host: repo.Knot,
89
+
Host: host,
89
90
}
90
91
l = l.With("knot", repo.Knot)
91
92
appview/state/router.go
appview/state/router.go
This file has not been changed.
go.mod
go.mod
This file has not been changed.
go.sum
go.sum
This file has not been changed.
knotserver/archive.go
knotserver/archive.go
This file has not been changed.
knotserver/git/git.go
knotserver/git/git.go
This file has not been changed.
knotserver/router.go
knotserver/router.go
This file has not been changed.
knotserver/xrpc/repo_archive.go
knotserver/xrpc/repo_archive.go
This file has not been changed.
knotserver/xrpc/xrpc.go
knotserver/xrpc/xrpc.go
This file has not been changed.
+56
lexicons/repo/archive.json
+56
lexicons/repo/archive.json
···
1
+
{
2
+
"lexicon": 1,
3
+
"id": "sh.tangled.repo.archive",
4
+
"defs": {
5
+
"main": {
6
+
"type": "query",
7
+
"description": "deprecated. use `/{did}/{reponame}/archive/{ref} endpoint instead",
8
+
"parameters": {
9
+
"type": "params",
10
+
"required": ["repo", "ref"],
11
+
"properties": {
12
+
"repo": {
13
+
"type": "string",
14
+
"description": "Repository identifier in format 'did:plc:.../repoName'"
15
+
},
16
+
"ref": {
17
+
"type": "string",
18
+
"description": "Git reference (branch, tag, or commit SHA)"
19
+
},
20
+
"format": {
21
+
"type": "string",
22
+
"description": "Archive format",
23
+
"enum": ["tar", "zip", "tar.gz", "tar.bz2", "tar.xz"],
24
+
"default": "tar.gz"
25
+
},
26
+
"prefix": {
27
+
"type": "string",
28
+
"description": "Prefix for files in the archive"
29
+
}
30
+
}
31
+
},
32
+
"output": {
33
+
"encoding": "*/*",
34
+
"description": "Binary archive data"
35
+
},
36
+
"errors": [
37
+
{
38
+
"name": "RepoNotFound",
39
+
"description": "Repository not found or access denied"
40
+
},
41
+
{
42
+
"name": "RefNotFound",
43
+
"description": "Git reference not found"
44
+
},
45
+
{
46
+
"name": "InvalidRequest",
47
+
"description": "Invalid request parameters"
48
+
},
49
+
{
50
+
"name": "ArchiveError",
51
+
"description": "Failed to create archive"
52
+
}
53
+
]
54
+
}
55
+
}
56
+
}
nix/gomod2nix.toml
nix/gomod2nix.toml
This file has not been changed.
History
7 rounds
2 comments
boltless.me
submitted
#6
2 commits
expand
collapse
appview,knotserver: support immutable nix flakeref link header
This will allow users to directly request archive from the knot without
using xrpc.
Xrpc doesn't fit here because it strips out the http headers which might
include valuable metadata like download filename or immutable link.
- implement archive on knot as `/{owner}/{repo}/archive/{ref}`
endpoint
- appview proxies the request to knot on `/archive` like it is doing for
git http endpoints.
if knot version isn't compatible, it will fallback to legacy xrpc
endpoint.
- rename the `git_http.go` file to generalized `proxy_knot.go` filaname
xrpc method `sh.tangled.repo.archive` will be deprecated in future
added `go-version` depenedency to make version constraints
Close: <https://tangled.org/tangled.org/core/issues/231>
Signed-off-by: Seongmin Lee <git@boltless.me>
lexicons,knotserver: remove
/xrpc/sh.tangled.repo.archive endpoint
replaced by `/{did}/{reponame}/archive/{ref}`. The lexicon definitions
will be removed later.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 1 comment
closed without merging
boltless.me
submitted
#5
2 commits
expand
collapse
appview,knotserver: support immutable nix flakeref link header
This will allow users to directly request archive from the knot without
using xrpc.
Xrpc doesn't fit here because it strips out the http headers which might
include valuable metadata like download filename or immutable link.
- implement archive on knot as `/{owner}/{repo}/archive/{ref}`
endpoint
- appview proxies the request to knot on `/archive` like it is doing for
git http endpoints.
if knot version isn't compatible, it will fallback to legacy xrpc
endpoint.
- rename the `git_http.go` file to generalized `proxy_knot.go` filaname
xrpc method `sh.tangled.repo.archive` will be deprecated in future
added `go-version` depenedency to make version constraints
Close: <https://tangled.org/tangled.org/core/issues/231>
Signed-off-by: Seongmin Lee <git@boltless.me>
lexicons,knotserver: remove
/xrpc/sh.tangled.repo.archive endpoint
replaced by `/{did}/{reponame}/archive/{ref}`. The lexicon definitions
will be removed later.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#4
3 commits
expand
collapse
nix: bump gomod2nix
Signed-off-by: Seongmin Lee <git@boltless.me>
appview,knotserver: support immutable nix flakeref link header
This will allow users to directly request archive from the knot without
using xrpc.
Xrpc doesn't fit here because it strips out the http headers which might
include valuable metadata like download filename or immutable link.
- implement archive on knot as `/{owner}/{repo}/archive/{ref}`
endpoint
- appview proxies the request to knot on `/archive` like it is doing for
git http endpoints.
if knot version isn't compatible, it will fallback to legacy xrpc
endpoint.
- rename the `git_http.go` file to generalized `proxy_knot.go` filaname
xrpc method `sh.tangled.repo.archive` will be deprecated in future
added `go-version` depenedency to make version constraints
Close: <https://tangled.org/tangled.org/core/issues/231>
Signed-off-by: Seongmin Lee <git@boltless.me>
lexicons,knotserver: remove
/xrpc/sh.tangled.repo.archive endpoint
replaced by `/{did}/{reponame}/archive/{ref}`. The lexicon definitions
will be removed later.
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#3
3 commits
expand
collapse
nix: bump gomod2nix
Signed-off-by: Seongmin Lee <git@boltless.me>
appview,knotserver: support immutable nix flakeref link header
This will allow users to directly request archive from the knot without
using xrpc.
Xrpc doesn't fit here because it strips out the http headers which might
include valuable metadata like download filename or immutable link.
- implement archive on knot as `/{owner}/{repo}/archive/{ref}`
endpoint
- appview proxies the request to knot on `/archive` like it is doing for
git http endpoints.
if knot version isn't compatible, it will fallback to legacy xrpc
endpoint.
- rename the `git_http.go` file to generalized `proxy_knot.go` filaname
xrpc method `sh.tangled.repo.archive` will be deprecated in future
added `go-version` depenedency to make version constraints
Close: <https://tangled.org/tangled.org/core/issues/231>
Signed-off-by: Seongmin Lee <git@boltless.me>
lexicons,knotserver: remove
sh.tangled.repo.archive
Xrpc is not a good way to implement this as Xrpc clients usually strips
out the response http headers.
The archive should be implemented in raw http endpoint instead like git
https endpoints
Signed-off-by: Seongmin Lee <git@boltless.me>
2/3 failed, 1/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#2
3 commits
expand
collapse
appview,knotserver: support knot http endpoint for archive
This will allow users to directly request archive from the knot without
using xrpc.
Xrpc doesn't fit here because it strips out the http headers which might
include valuable metadata like download filename or immutable link.
- remove xrpc method `sh.tangled.repo.archive`
- reimplement archive on knot as `/{owner}/{repo}/archive/{ref}`
endpoint
- appview will just proxy the request to knot on `/archive` like it is
doing for git http endpoints
- rename the `git_http.go` file to generalized `proxy_knot.go` filaname
Signed-off-by: Seongmin Lee <git@boltless.me>
knotserver: support immutable nix flakeref link header
Close: #231
Signed-off-by: Seongmin Lee <git@boltless.me>
lexicons,knotserver: remove
sh.tangled.repo.archive
Xrpc is not a good way to implement this as Xrpc clients usually strips
out the response http headers.
The archive should be implemented in raw http endpoint instead like git
https endpoints
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#1
1 commit
expand
collapse
appview,knotserver: immutable nix flakeref link header
Close: #231
Signed-off-by: Seongmin Lee <git@boltless.me>
3/3 success
expand
collapse
expand 0 comments
boltless.me
submitted
#0
1 commit
expand
collapse
appview,knotserver: immutable nix flakeref link header
Close: #231
Signed-off-by: Seongmin Lee <git@boltless.me>
closing for https://tangled.org/tangled.org/core/pulls/1001