tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/{oauth,pages}: cleanup unused codes #1022

open opened by boltless.me targeting master from sl/uvpzuszrulvq
  • AccountRegistry.OtherAccounts() is not used anywhere
  • Removed several legacy session value names from oauth/consts.go
  • We can just embed the oauth.GetUser() now

Signed-off-by: Seongmin Lee git@boltless.me

STACK 11
#800 draft: appview: service layer
0/3
0
#19
#1027 appview: remove oauth.User type
1/3
0
#8
#1021 appview/pulls: remove dependencies to oauth.MultiAccountUser
3/3
0
#8
#1026 appview/pages: don't access MultiAccountUser.Active from template
1/3
0
#8
#1025 appview/oauth: remove .Handle from oauth.AccountInfo
1/3
0
#8
#1024 appview/oauth: remove AuthReturnInfo
1/3
0
#8
#1020 appview/{oauth,pages,state}: remove unused AddAccount session data
1/3
0
#8
#1023 appview/{pages,state}: simplify LoginPage params
1/3
0
#8
#1022 appview/{oauth,pages}: cleanup unused codes
1/3
0
#8
#1188 appview: don't trust oauth.ClientSessionData
1/3
0
#3
#1150 appview: use explicit TANGLED_PDS_HANDLE_SUFFIX for tngl.sh user check
1/3
1
#4
ABANDONED PULLS 2
#1149 appview: wip
2/3
0
#0
#1028 appview/{oauth,pages}: remove Pds field from oauth.User
2/3
0
#4
Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3mdcq5ouz5l22
+2 -2
Interdiff #2 → #3
appview/oauth/accounts.go

This patch was likely rebased, as context lines do not match.

appview/oauth/accounts_test.go

This file has not been changed.

appview/oauth/consts.go

This file has not been changed.

appview/oauth/oauth.go

This patch was likely rebased, as context lines do not match.

+2 -2
appview/pages/templates/user/login.html
··· 13 13 14 14 {{ if and .LoggedInUser .LoggedInUser.Accounts }} 15 15 {{ $accounts := .LoggedInUser.Accounts }} 16 - {{ if $accounts }} 17 16 <div class="my-4 border border-gray-200 dark:border-gray-700 rounded overflow-hidden"> 18 17 <div class="px-3 py-2 bg-gray-50 dark:bg-gray-800 border-b border-gray-200 dark:border-gray-700"> 19 18 <span class="text-xs text-gray-500 dark:text-gray-400 uppercase tracking-wide font-medium">Saved accounts</span> ··· 33 32 34 33 {{ if and .LoggedInUser .LoggedInUser.Accounts }} 35 34 {{ $accounts := .LoggedInUser.Accounts }} 35 + {{ if $accounts }} 36 36 <div class="my-4 border border-gray-200 dark:border-gray-700 rounded overflow-hidden"> 37 37 <div class="px-3 py-2 bg-gray-50 dark:bg-gray-800 border-b border-gray-200 dark:border-gray-700"> 38 38 <span class="text-xs text-gray-500 dark:text-gray-400 uppercase tracking-wide font-medium">Saved accounts</span> ··· 47 47 </div> 48 48 </div> 49 49 {{ end }} 50 - {{ end }} 51 50 52 51 <form 53 52 class="mt-4 group" ··· 67 66 </div> 68 67 </div> 69 68 {{ end }} 69 + {{ end }} 70 70 71 71 <form 72 72 class="mt-4"
appview/state/profile.go

This patch was likely rebased, as context lines do not match.

History

9 rounds 0 comments
sign up or login to add to the discussion
boltless.me submitted #8
diff interdiff
1 commit
expand
bf91f44e
appview/{oauth,pages}: cleanup unused codes
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
no conflicts, ready to merge
expand 0 comments
boltless.me submitted #7
diff interdiff
1 commit
expand
678e974e
appview/{oauth,pages}: cleanup unused codes
2/3 timeout, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #6
diff interdiff
1 commit
expand
678e974e
appview/{oauth,pages}: cleanup unused codes
2/3 timeout, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #5
diff interdiff
1 commit
expand
9cd1a5e9
appview/{oauth,pages}: cleanup unused codes
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #4
diff interdiff
1 commit
expand
88d05784
appview/{oauth,pages}: cleanup unused codes
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #3
diff
1 commit
expand
2d0188fb
appview/{oauth,pages}: cleanup unused codes
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #2
diff interdiff
1 commit
expand
81a8e88a
appview/{oauth,pages}: cleanup unused codes
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #1
diff interdiff
1 commit
expand
f3c14331
appview/{oauth,pages}: cleanup unused codes
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #0
diff
1 commit
expand
c745ef9e
appview/{oauth,pages}: cleanup unused codes
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments