tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/{oauth,pages}: cleanup unused codes #1022

open opened by boltless.me targeting master from sl/uvpzuszrulvq
  • AccountRegistry.OtherAccounts() is not used anywhere
  • Removed several legacy session value names from oauth/consts.go
  • We can just embed the oauth.GetUser() now

Signed-off-by: Seongmin Lee git@boltless.me

STACK 10
#800 draft: appview: service layer
2/3
0
#13
#1027 appview: remove oauth.User type
1/3
0
#2
#1021 appview/pulls: remove dependencies to oauth.MultiAccountUser
1/3
0
#2
#1026 appview/pages: don't access MultiAccountUser.Active from template
1/3
0
#2
#1025 appview/oauth: remove .Handle from oauth.AccountInfo
3/3
0
#2
#1024 appview/oauth: remove AuthReturnInfo
2/3
0
#2
#1020 appview/{oauth,pages,state}: remove unused AddAccount session data
1/3
0
#2
#1023 appview/{pages,state}: simplify LoginPage params
1/3
0
#2
#1022 appview/{oauth,pages}: cleanup unused codes
3/3
0
#2
#1028 appview/{oauth,pages}: remove Pds field from oauth.User
2/3
0
#2
Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3mdcq5ouz5l22
Interdiff #1 → #2
unified split
appview/oauth/accounts.go

This file has not been changed.

appview/oauth/accounts_test.go

This file has not been changed.

appview/oauth/consts.go

This file has not been changed.

appview/oauth/oauth.go

This patch was likely rebased, as context lines do not match.

appview/pages/templates/user/login.html

This file has not been changed.

appview/state/profile.go

This file has not been changed.

History

3 rounds 0 comments
sign up or login to add to the discussion
boltless.me submitted #2
interdiff
1 commit
expand
81a8e88a
appview/{oauth,pages}: cleanup unused codes
3/3 success
expand
build.yml
fmt.yml
test.yml
merge conflicts detected
expand
  • appview/pages/templates/user/login.html:33
  • appview/state/profile.go:817
expand 0 comments
boltless.me submitted #1
diff interdiff
1 commit
expand
f3c14331
appview/{oauth,pages}: cleanup unused codes
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments
boltless.me submitted #0
diff
1 commit
expand
c745ef9e
appview/{oauth,pages}: cleanup unused codes
2/3 failed, 1/3 success
expand
build.yml
fmt.yml
test.yml
expand 0 comments