tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/oauth: create tangled profile on first login #1010

merged opened by anirudh.fi targeting master from icy/tolqpt

Creates an empty sh.tangled.actor.profile on first login. This should prevent profile picture uploads from breaking due to profile record existing beforehand.

This should also allow for us to estimate total users better globally.

Signed-off-by: Anirudh Oppiliappan anirudh@tangled.org

STACK 9
#1013 appview/state: add the ability to remove your avatar
3/3
2
#0
#1010 appview/oauth: create tangled profile on first login
3/3
3
#2
#1008 appview/pages: get avatar cid to bust cache
3/3
1
#3
#896 appview/pages: render a placeholder avatar when there's no did
3/3
1
#5
#894 appview/pages: upload and render avatar
3/3
2
#6
#893 avatar: fetch tangled avatar before falling back to bsky & random color
3/3
2
#6
#892 appview/state: handle profile pic uploads
3/3
1
#6
#891 appview/{db,models}: add avatar to profile
3/3
0
#6
#890 lexicons,api: add avatar field to profile lexicon
3/3
0
#6
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:hwevmowznbiukdf6uk5dwrrq/sh.tangled.repo.pull/3mcyvm2bhkj22
+24 -15
Interdiff #0 → #1
unified split
+24 -15
appview/oauth/handler.go
··· 17 17 "github.com/posthog/posthog-go" 18 18 "tangled.org/core/api/tangled" 19 19 "tangled.org/core/appview/db" 20 + "tangled.org/core/appview/models" 20 21 "tangled.org/core/consts" 21 22 "tangled.org/core/orm" 22 23 "tangled.org/core/tid" ··· 198 199 did := sessData.AccountDID.String() 199 200 l := o.Logger.With("did", did) 200 201 201 - sess, err := o.ClientApp.ResumeSession(ctx, sessData.AccountDID, sessData.SessionID) 202 - if err != nil { 203 - l.Error("failed to resume session for profile creation", "err", err) 204 - return 205 - } 206 - client := sess.APIClient() 207 - 208 - getRecordResp, err := comatproto.RepoGetRecord(ctx, client, "", tangled.ActorProfileNSID, did, "self") 209 - if err == nil && getRecordResp != nil { 210 - l.Debug("profile already exists") 202 + _, err := db.GetProfile(o.Db, did) 203 + if err == nil { 204 + l.Debug("profile already exists in DB") 211 205 return 212 206 } 213 207 214 208 l.Debug("creating empty Tangled profile") 215 209 216 - emptyProfile := &tangled.ActorProfile{ 217 - LexiconTypeID: tangled.ActorProfileNSID, 210 + sess, err := o.ClientApp.ResumeSession(ctx, sessData.AccountDID, sessData.SessionID) 211 + if err != nil { 212 + l.Error("failed to resume session for profile creation", "err", err) 213 + return 218 214 } 215 + client := sess.APIClient() 219 216 220 217 _, err = comatproto.RepoPutRecord(ctx, client, &comatproto.RepoPutRecord_Input{ 221 218 Collection: tangled.ActorProfileNSID, 222 219 Repo: did, 223 220 Rkey: "self", 224 - Record: &lexutil.LexiconTypeDecoder{Val: emptyProfile}, 221 + Record: &lexutil.LexiconTypeDecoder{Val: &tangled.ActorProfile{}}, 225 222 }) 226 223 227 224 if err != nil { 228 - l.Error("failed to create empty profile", "err", err) 225 + l.Error("failed to create empty profile on PDS", "err", err) 226 + return 227 + } 228 + 229 + tx, err := o.Db.BeginTx(ctx, nil) 230 + if err != nil { 231 + l.Error("failed to start transaction", "err", err) 232 + return 233 + } 234 + 235 + emptyProfile := &models.Profile{Did: did} 236 + if err := db.UpsertProfile(tx, emptyProfile); err != nil { 237 + l.Error("failed to create empty profile in DB", "err", err) 229 238 return 230 239 } 231 240 232 - l.Debug("successfully created empty Tangled profile") 241 + l.Debug("successfully created empty Tangled profile on PDS and DB") 233 242 } 234 243 235 244 // create a session using apppasswords

History

3 rounds 3 comments
sign up or login to add to the discussion
anirudh.fi submitted #2
diff interdiff
1 commit
expand
9ca8a367
appview/oauth: create tangled profile on first login
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 1 comment
oppi.li

this change lgtm! will test out the whole thing.

pull request successfully merged
anirudh.fi submitted #1
interdiff
1 commit
expand
9ca8a367
appview/oauth: create tangled profile on first login
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 1 comment
anirudh.fi

Makes sense, done.

anirudh.fi submitted #0
diff
1 commit
expand
cc28f84b
appview/oauth: create tangled profile on first login
expand 1 comment
oppi.li

do we need this? would have thought just new(tangled.ActorProfile) or &tangled.ActorProfile{} would suffice.

i would also suggest that we do this:

  • change the existence check to look in the DB instead of the user's PDS
  • if not present, putRecord in the PDS as well as insert an empty record in the DB

this way the existence check, upon login, is much faster.