tangled.org / core
Monorepo for Tangled tangled.org
fork atom

appview/oauth: create tangled profile on first login #1010

merged opened by anirudh.fi targeting master from icy/tolqpt

Creates an empty sh.tangled.actor.profile on first login. This should prevent profile picture uploads from breaking due to profile record existing beforehand.

This should also allow for us to estimate total users better globally.

Signed-off-by: Anirudh Oppiliappan anirudh@tangled.org

STACK 9
#1013 appview/state: add the ability to remove your avatar
3/3
2
#0
#1010 appview/oauth: create tangled profile on first login
3/3
3
#2
#1008 appview/pages: get avatar cid to bust cache
3/3
1
#3
#896 appview/pages: render a placeholder avatar when there's no did
3/3
1
#5
#894 appview/pages: upload and render avatar
3/3
2
#6
#893 avatar: fetch tangled avatar before falling back to bsky & random color
3/3
2
#6
#892 appview/state: handle profile pic uploads
3/3
1
#6
#891 appview/{db,models}: add avatar to profile
3/3
0
#6
#890 lexicons,api: add avatar field to profile lexicon
3/3
0
#6
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:hwevmowznbiukdf6uk5dwrrq/sh.tangled.repo.pull/3mcyvm2bhkj22
+52
Diff #2
unified split
+52
appview/oauth/handler.go
··· 10 10 "slices" 11 11 "time" 12 12 13 + comatproto "github.com/bluesky-social/indigo/api/atproto" 13 14 "github.com/bluesky-social/indigo/atproto/auth/oauth" 15 + lexutil "github.com/bluesky-social/indigo/lex/util" 14 16 "github.com/go-chi/chi/v5" 15 17 "github.com/posthog/posthog-go" 16 18 "tangled.org/core/api/tangled" 17 19 "tangled.org/core/appview/db" 20 + "tangled.org/core/appview/models" 18 21 "tangled.org/core/consts" 19 22 "tangled.org/core/orm" 20 23 "tangled.org/core/tid" ··· 82 85 } 83 86 84 87 o.Logger.Debug("session saved successfully") 88 + 85 89 go o.addToDefaultKnot(sessData.AccountDID.String()) 86 90 go o.addToDefaultSpindle(sessData.AccountDID.String()) 91 + go o.ensureTangledProfile(sessData) 87 92 88 93 if !o.Config.Core.Dev { 89 94 err = o.Posthog.Enqueue(posthog.Capture{ ··· 189 194 l.Debug("successfully addeds to default Knot") 190 195 } 191 196 197 + func (o *OAuth) ensureTangledProfile(sessData *oauth.ClientSessionData) { 198 + ctx := context.Background() 199 + did := sessData.AccountDID.String() 200 + l := o.Logger.With("did", did) 201 + 202 + _, err := db.GetProfile(o.Db, did) 203 + if err == nil { 204 + l.Debug("profile already exists in DB") 205 + return 206 + } 207 + 208 + l.Debug("creating empty Tangled profile") 209 + 210 + sess, err := o.ClientApp.ResumeSession(ctx, sessData.AccountDID, sessData.SessionID) 211 + if err != nil { 212 + l.Error("failed to resume session for profile creation", "err", err) 213 + return 214 + } 215 + client := sess.APIClient() 216 + 217 + _, err = comatproto.RepoPutRecord(ctx, client, &comatproto.RepoPutRecord_Input{ 218 + Collection: tangled.ActorProfileNSID, 219 + Repo: did, 220 + Rkey: "self", 221 + Record: &lexutil.LexiconTypeDecoder{Val: &tangled.ActorProfile{}}, 222 + }) 223 + 224 + if err != nil { 225 + l.Error("failed to create empty profile on PDS", "err", err) 226 + return 227 + } 228 + 229 + tx, err := o.Db.BeginTx(ctx, nil) 230 + if err != nil { 231 + l.Error("failed to start transaction", "err", err) 232 + return 233 + } 234 + 235 + emptyProfile := &models.Profile{Did: did} 236 + if err := db.UpsertProfile(tx, emptyProfile); err != nil { 237 + l.Error("failed to create empty profile in DB", "err", err) 238 + return 239 + } 240 + 241 + l.Debug("successfully created empty Tangled profile on PDS and DB") 242 + } 243 + 192 244 // create a session using apppasswords 193 245 type session struct { 194 246 AccessJwt string `json:"accessJwt"`

History

3 rounds 3 comments
sign up or login to add to the discussion
anirudh.fi submitted #2
interdiff
1 commit
expand
9ca8a367
appview/oauth: create tangled profile on first login
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 1 comment
oppi.li

this change lgtm! will test out the whole thing.

pull request successfully merged
anirudh.fi submitted #1
diff interdiff
1 commit
expand
9ca8a367
appview/oauth: create tangled profile on first login
3/3 success
expand
build.yml
fmt.yml
test.yml
expand 1 comment
anirudh.fi

Makes sense, done.

anirudh.fi submitted #0
diff
1 commit
expand
cc28f84b
appview/oauth: create tangled profile on first login
expand 1 comment
oppi.li

do we need this? would have thought just new(tangled.ActorProfile) or &tangled.ActorProfile{} would suffice.

i would also suggest that we do this:

  • change the existence check to look in the DB instead of the user's PDS
  • if not present, putRecord in the PDS as well as insert an empty record in the DB

this way the existence check, upon login, is much faster.