PHP 8.5: Replace semicolons with colons in switch case statements

Summary:
Using semicolons was depreacted in PHP 8.5 per https://wiki.php.net/rfc/deprecations_php_8_5 and https://github.com/php/php-src/commit/5f8d648af6ef4e29a3c7f2b2029d08466c12bc6f

Closes T16316

Test Plan: None.

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16316

Differential Revision: https://we.phorge.it/D26442

src/aphront/headerparser/AphrontHTTPHeaderParser.php

···
       $c = $content[$ii];
 
       switch ($state) {
-        case 'prekey';
+        case 'prekey':
           // We're eating space in front of a key.
           if ($c == ' ') {
             $ii++;
···
           $pair_name = '';
           $state = 'key';
           break;
-        case 'key';
+        case 'key':
           // We're parsing a key name until we find "=" or ";".
           if ($c == ';') {
             $state = 'done';

src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php

···
         }
         break;
 
-      case PhabricatorAuthSSHKeyTransaction::TYPE_KEY;
+      case PhabricatorAuthSSHKeyTransaction::TYPE_KEY:
         $missing = $this->validateIsEmptyTextField(
           $object->getName(),
           $xactions);

src/applications/auth/factor/__tests__/PhabricatorAuthInviteTestCase.php

···
               case 'out':
                 $viewer = $logged_out;
                 break;
-              case 'in';
+              case 'in':
                 $viewer = $logged_in;
                 break;
               case 'same':

src/applications/calendar/parser/data/PhutilCalendarRecurrenceRule.php

···
         case 'INTERVAL':
         case 'WKST':
         case 'COUNT':
-        case 'UNTIL';
+        case 'UNTIL':
           break;
         default:
           $value = explode(',', $value);

src/applications/config/schema/PhabricatorConfigSchemaSpec.php

···
             $column_type = 'longtext';
           }
           break;
-        case 'fulltext';
+        case 'fulltext':
           // MySQL (at least, under MyISAM) refuses to create a FULLTEXT index
           // on a LONGBLOB column. We'd also lose case insensitivity in search.
           // Force this column to utf8 collation. This will truncate results
···
           $column_type = 'bigint(20)';
           break;
         case 'phid':
-        case 'policy';
+        case 'policy':
         case 'hashpath64':
         case 'ipaddress':
           $column_type = 'varbinary(64)';

src/applications/console/plugin/DarkConsoleServicesPlugin.php

···
                 $cur_badness = 1;
                 $cur_reason = 'Const';
                 break;
-              case 'eq_ref';
+              case 'eq_ref':
                 $cur_badness = 2;
                 $cur_reason = 'EqRef';
                 break;

src/applications/differential/storage/DifferentialDiffTransaction.php

···
 
   public function getActionName() {
     switch ($this->getTransactionType()) {
-      case self::TYPE_DIFF_CREATE;
+      case self::TYPE_DIFF_CREATE:
         return pht('Created');
     }
 
···
     $new = $this->getNewValue();
 
     switch ($this->getTransactionType()) {
-      case self::TYPE_DIFF_CREATE;
+      case self::TYPE_DIFF_CREATE:
         return pht(
           '%s created this diff.',
           $author_handle);

src/applications/differential/storage/DifferentialTransaction.php

···
     $tags = array();
 
     switch ($this->getTransactionType()) {
-      case PhabricatorTransactions::TYPE_SUBSCRIBERS;
+      case PhabricatorTransactions::TYPE_SUBSCRIBERS:
         $tags[] = self::MAILTAG_CC;
         break;
       case self::TYPE_ACTION:

src/applications/files/storage/PhabricatorFile.php

···
     }
 
     switch ($matches[1]) {
-      case 'jpg';
+      case 'jpg':
       case 'jpeg':
         return function_exists('imagejpeg');
       case 'png':

src/applications/search/controller/PhabricatorSearchRelationshipSourceController.php

···
         $query->setParameter('ownerPHIDs', array($viewer->getPHID()));
         $query->setParameter('statuses', array($status_open));
         break;
-      case 'created';
+      case 'created':
         $query->setParameter('authorPHIDs', array($viewer->getPHID()));
         $query->setParameter('statuses', array($status_open));
         break;

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

···
 
   public function getColor() {
     switch ($this->getTransactionType()) {
-      case PhabricatorTransactions::TYPE_COMMENT;
+      case PhabricatorTransactions::TYPE_COMMENT:
         $comment = $this->getComment();
         if ($comment && $comment->getIsRemoved()) {
           return 'grey';
···
             return 'sky';
         }
         break;
-      case PhabricatorTransactions::TYPE_MFA;
+      case PhabricatorTransactions::TYPE_MFA:
         return 'pink';
     }
     return null;

support/startup/PhabricatorStartup.php

···
         case INPUT_COOKIE:
           $_COOKIE = array_merge($_COOKIE, $filtered);
           break;
-        case INPUT_ENV;
+        case INPUT_ENV:
           $env = array_merge($_ENV, $filtered);
           $_ENV = self::filterEnvSuperglobal($env);
           break;