@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Differential: Rename "Foist Upon" to "Change Author"

Summary:
Use terms which actually communicate which aspect of a revision will be changed by performing an action.
(I rate clarity of outcomes of actions higher than being forced to interpret ambiguous vocabulary.)

Most action dropdown items are already prefixed with "Change $something".
The existing code in `DifferentialRevisionAuthorTransaction` already fell back to "changed the author of this revision" before this very change.

Closes T16301

Test Plan:
* Look at the options in the action dropdown in a Differential revision
* Foist upon someone, look at the log entries

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16301

Differential Revision: https://we.phorge.it/D26428

+8 -7
+6 -5
src/applications/differential/editor/DifferentialRevisionEditEngine.php
··· 182 182 ->setDatasource(new PhabricatorPeopleDatasource()) 183 183 ->setTransactionType( 184 184 DifferentialRevisionAuthorTransaction::TRANSACTIONTYPE) 185 - ->setDescription(pht('Foist this revision upon someone else.')) 186 - ->setConduitDescription(pht('Foist this revision upon another user.')) 185 + ->setDescription(pht('Make someone else the author of this revision.')) 186 + ->setConduitDescription( 187 + pht('Make another user the author of this revision.')) 187 188 ->setConduitTypeDescription(pht('New author.')) 188 189 ->setSingleValue($object->getAuthorPHID()); 189 190 ··· 193 194 $author_field->setIsHidden(true); 194 195 } 195 196 196 - // Only show the "Foist Upon" comment action to the current revision 197 - // author. Other users can use "Edit Revision", it's just very unlikley 197 + // Only show the "Change Author" comment action to the current revision 198 + // author. Other users can use "Edit Revision", it's just very unlikely 198 199 // that they're interested in this action. 199 200 if ($viewer->getPHID() === $object->getAuthorPHID()) { 200 - $author_field->setCommentActionLabel(pht('Foist Upon')); 201 + $author_field->setCommentActionLabel(pht('Change Author')); 201 202 } 202 203 203 204 $fields[] = $author_field;
+2 -2
src/applications/differential/xaction/DifferentialRevisionAuthorTransaction.php
··· 97 97 if ($is_foist) { 98 98 if ($new_phid) { 99 99 return pht( 100 - '%s foisted this revision upon %s.', 100 + '%s changed the author of this revision to %s.', 101 101 $this->renderAuthor(), 102 102 $this->renderNewHandle()); 103 103 } else { ··· 106 106 // the preview if you temporarily delete the tokenizer value. 107 107 108 108 return pht( 109 - '%s foisted this revision upon...', 109 + '%s changed the author of this revision to...', 110 110 $this->renderAuthor()); 111 111 } 112 112 }