Fix dangerous casts

On Windows 64-bit, the size of long is 32-bit, thus any pointer to long cast is
not valid. In any case, one should use intptr_t and ptrdiff_t when casting
to integers. This commit attempts to fix all instances reported by GCC.
When relevant, I replaced code by the macros PTR_ADD, ALIGN_UP from system.h

Change-Id: I2273b0e8465d3c4689824717ed5afa5ed238a2dc

apps/gui/skin_engine/skin_parser.c

···
         skin_buffer = wps_buffer;
         wps_buffer = (char*)buf;
     }
-    skin_buffer = (void *)(((unsigned long)skin_buffer + 3) & ~3);
+    skin_buffer = ALIGN_UP(skin_buffer, 4); /* align on 4-byte boundary */
     buffersize -= 3;
 #ifdef HAVE_BACKDROP_IMAGE
     backdrop_filename = "-";

apps/misc.c

···
         count++;
         if (next)
         {
-            pos = buf_size - ((long)next - (long)buf) - 1;
+            pos = buf_size - ((intptr_t)next - (intptr_t)buf) - 1;
             memmove(buf, next, pos);
         }
         else

apps/plugins/doom/d_deh.c

···
                S_sfx[indexnum].priority = (int)value;
             else
                if (!strcasecmp(key,deh_sfxinfo[3]))  // Zero 1
-                  S_sfx[indexnum].link = (sfxinfo_t *)((long) value);
+                  S_sfx[indexnum].link = (sfxinfo_t *)((intptr_t) value);
                else
                   if (!strcasecmp(key,deh_sfxinfo[4]))  // Zero 2
                      S_sfx[indexnum].pitch = (int)value;
···
                         S_sfx[indexnum].volume = (int)value;
                      else
                         if (!strcasecmp(key,deh_sfxinfo[6]))  // Zero 4
-                           S_sfx[indexnum].data = (void *) ((long) value); // killough 5/3/98: changed cast
+                           S_sfx[indexnum].data = (void *) ((intptr_t) value); // killough 5/3/98: changed cast
                         else
                            if (!strcasecmp(key,deh_sfxinfo[7]))  // Neg. One 1
                               S_sfx[indexnum].usefulness = (int)value;

apps/plugins/doom/d_main.c

···
       // for statistics driver
       extern  void* statcopy;
 
-      statcopy = (void*)(long)atoi(myargv[p+1]);
+      statcopy = (void*)(intptr_t)atoi(myargv[p+1]);
       printf ("External statistics registered.\n");
    }
 

apps/plugins/doom/p_saveg.c

···
 
 // Pads save_p to a 4-byte boundary
 //  so that the load/save works on SGI&Gecko.
-#define PADSAVEP()    do { save_p += (4 - ((unsigned long) save_p & 3)) & 3; } while (0)
+#define PADSAVEP()    do { save_p += (4 - ((intptr_t) save_p & 3)) & 3; } while (0)
 //
 // P_ArchivePlayers
 //
···
          for (j=0 ; j<NUMPSPRITES ; j++)
             if (players[i]. psprites[j].state)
                players[i]. psprites[j].state =
-                  &states[ (unsigned long)players[i].psprites[j].state ];
+                  &states[ (intptr_t)players[i].psprites[j].state ];
       }
 }
 
···
    number_of_thinkers = 0;
    for (th = thinkercap.next ; th != &thinkercap ; th=th->next)
       if (th->function == P_MobjThinker)
-         th->prev = (thinker_t *)(long)(++number_of_thinkers);
+         th->prev = (thinker_t *)(intptr_t)(++number_of_thinkers);
 }
 
 // phares 9/13/98: Moved this code outside of P_ArchiveThinkers so the
···
       PADSAVEP();
       memcpy (mobj, save_p, sizeof(mobj_t));
       save_p += sizeof(mobj_t);
-      mobj->state = states + (unsigned long) mobj->state;
+      mobj->state = states + (intptr_t) mobj->state;
 
       if (mobj->player)
-         (mobj->player = &players[(unsigned long) mobj->player - 1]) -> mo = mobj;
+         (mobj->player = &players[(intptr_t) mobj->player - 1]) -> mo = mobj;
 
       P_SetThingPosition (mobj);
       mobj->info = &mobjinfo[mobj->type];
···
             ceiling_t *ceiling = Z_Malloc (sizeof(*ceiling), PU_LEVEL, NULL);
             memcpy (ceiling, save_p, sizeof(*ceiling));
             save_p += sizeof(*ceiling);
-            ceiling->sector = &sectors[(unsigned long)ceiling->sector];
+            ceiling->sector = &sectors[(intptr_t)ceiling->sector];
             ceiling->sector->ceilingdata = ceiling; //jff 2/22/98
 
             if (ceiling->thinker.function)
···
             vldoor_t *door = Z_Malloc (sizeof(*door), PU_LEVEL, NULL);
             memcpy (door, save_p, sizeof(*door));
             save_p += sizeof(*door);
-            door->sector = &sectors[(unsigned long)door->sector];
+            door->sector = &sectors[(intptr_t)door->sector];
 
             //jff 1/31/98 unarchive line remembered by door as well
-            door->line = (long)door->line!=-1? &lines[(unsigned long)door->line] : NULL;
+            door->line = (intptr_t)door->line!=-1? &lines[(intptr_t)door->line] : NULL;
 
             door->sector->ceilingdata = door;       //jff 2/22/98
             door->thinker.function = T_VerticalDoor;
···
             floormove_t *floor = Z_Malloc (sizeof(*floor), PU_LEVEL, NULL);
             memcpy (floor, save_p, sizeof(*floor));
             save_p += sizeof(*floor);
-            floor->sector = &sectors[(unsigned long)floor->sector];
+            floor->sector = &sectors[(intptr_t)floor->sector];
             floor->sector->floordata = floor; //jff 2/22/98
             floor->thinker.function = T_MoveFloor;
             P_AddThinker (&floor->thinker);
···
             plat_t *plat = Z_Malloc (sizeof(*plat), PU_LEVEL, NULL);
             memcpy (plat, save_p, sizeof(*plat));
             save_p += sizeof(*plat);
-            plat->sector = &sectors[(unsigned long)plat->sector];
+            plat->sector = &sectors[(intptr_t)plat->sector];
             plat->sector->floordata = plat; //jff 2/22/98
 
             if (plat->thinker.function)
···
             lightflash_t *flash = Z_Malloc (sizeof(*flash), PU_LEVEL, NULL);
             memcpy (flash, save_p, sizeof(*flash));
             save_p += sizeof(*flash);
-            flash->sector = &sectors[(unsigned long)flash->sector];
+            flash->sector = &sectors[(intptr_t)flash->sector];
             flash->thinker.function = T_LightFlash;
             P_AddThinker (&flash->thinker);
             break;
···
             strobe_t *strobe = Z_Malloc (sizeof(*strobe), PU_LEVEL, NULL);
             memcpy (strobe, save_p, sizeof(*strobe));
             save_p += sizeof(*strobe);
-            strobe->sector = &sectors[(unsigned long)strobe->sector];
+            strobe->sector = &sectors[(intptr_t)strobe->sector];
             strobe->thinker.function = T_StrobeFlash;
             P_AddThinker (&strobe->thinker);
             break;
···
             glow_t *glow = Z_Malloc (sizeof(*glow), PU_LEVEL, NULL);
             memcpy (glow, save_p, sizeof(*glow));
             save_p += sizeof(*glow);
-            glow->sector = &sectors[(unsigned long)glow->sector];
+            glow->sector = &sectors[(intptr_t)glow->sector];
             glow->thinker.function = T_Glow;
             P_AddThinker (&glow->thinker);
             break;
···
             fireflicker_t *flicker = Z_Malloc (sizeof(*flicker), PU_LEVEL, NULL);
             memcpy (flicker, save_p, sizeof(*flicker));
             save_p += sizeof(*flicker);
-            flicker->sector = &sectors[(unsigned long)flicker->sector];
+            flicker->sector = &sectors[(intptr_t)flicker->sector];
             flicker->thinker.function = T_FireFlicker;
             P_AddThinker (&flicker->thinker);
             break;
···
             elevator_t *elevator = Z_Malloc (sizeof(*elevator), PU_LEVEL, NULL);
             memcpy (elevator, save_p, sizeof(*elevator));
             save_p += sizeof(*elevator);
-            elevator->sector = &sectors[(unsigned long)elevator->sector];
+            elevator->sector = &sectors[(intptr_t)elevator->sector];
             elevator->sector->floordata = elevator; //jff 2/22/98
             elevator->sector->ceilingdata = elevator; //jff 2/22/98
             elevator->thinker.function = T_MoveElevator;

apps/plugins/doom/z_zone.c

···
 
    // Align on cache boundary
 
-   zone = (memblock_t *) ((unsigned long)zonebase + CACHE_ALIGN -
-                         ((unsigned long)zonebase & (CACHE_ALIGN-1)));
+   zone = (memblock_t *) ((intptr_t)zonebase + CACHE_ALIGN -
+                            ((intptr_t)zonebase & (CACHE_ALIGN-1)));
 
    rover = zone;                            // Rover points to base of zone mem
    zone->next = zone->prev = zone;          // Single node

apps/plugins/goban/util.c

···
 void *
 align_buffer (void *buffer, size_t * buffer_size)
 {
-    unsigned int wasted = (-(long) buffer) & 3;
+    unsigned int wasted = (-(intptr_t) buffer) & 3;
 
     if (!buffer || !buffer_size)
     {
···
 
     *buffer_size -= wasted;
 
-    return (void *) (((char *) buffer) + wasted);
+    return PTR_ADD(buffer, wasted);
 }
 
 

apps/plugins/lib/simple_viewer.c

···
         w = 1;
 #else
         unsigned short ch;
-        n = ((long)rb->utf8decode(ptr, &ch) - (long)ptr);
+        n = ((intptr_t)rb->utf8decode(ptr, &ch) - (intptr_t)ptr);
         if (rb->is_diacritic(ch, NULL))
             w = 0;
         else

apps/plugins/lib/strncpy.c

···
 #include <limits.h>
 #include "plugin.h"
 #include "_ansi.h"
+#include <stdint.h>
 
 /*SUPPRESS 560*/
 /*SUPPRESS 530*/
 
 /* Nonzero if either X or Y is not aligned on a "long" boundary.  */
 #define ROCKBOX_UNALIGNED(X, Y) \
-  (((long)X & (sizeof (long) - 1)) | ((long)Y & (sizeof (long) - 1)))
+  (((uintptr_t)X & (sizeof (long) - 1)) | ((uintptr_t)Y & (sizeof (long) - 1)))
 
 #if LONG_MAX == 2147483647L
 #define DETECTNULL(X) (((X) - 0x01010101) & ~(X) & 0x80808080)

apps/plugins/lrcplayer.c

···
             c = rb->utf8seek(cr.str, 1);
             w = 1;
 #else
-            c = ((long)rb->utf8decode(cr.str, &ch) - (long)cr.str);
+            c = ((intptr_t)rb->utf8decode(cr.str, &ch) - (intptr_t)cr.str);
             if (rb->is_diacritic(ch, NULL))
                 w = 0;
             else
···
         lrc_line->time_start = (time/10)*10;
         lrc_line->old_time_start = lrc_line->time_start;
         add_lrc_line(lrc_line, NULL);
-        file_offset += (long)tagend - (long)str;
+        file_offset += (intptr_t)tagend - (intptr_t)str;
         str = tagend;
     }
     if (!first_lrc_line)
···
         if (!tagend) break;
         *tagend = 0;
         time = get_time_value(tagstart+1, false,
-                                file_offset + ((long)tagstart - (long)str));
+                                file_offset + ((intptr_t)tagstart - (intptr_t)str));
         *tagend++ = '>';
         if (time < 0)
         {
···
                 return false;
             nword++;
         }
-        file_offset += (long)tagend - (long)str;
+        file_offset += (intptr_t)tagend - (intptr_t)str;
         tagstart = str = tagend;
         time_start = time;
     }
···
         }
     }
     if(ff_found) *ff_found = _ff_found;
-    return (long)wp - (long)tag;
+    return (intptr_t)wp - (intptr_t)tag;
 }
 
 static int read_unsynched(int fd, void *buf, int len, bool *ff_found)
···
                 utf_decode = rb->utf16BEdecode;
         }
     }
-    bytesread -= (long)p - (long)tag;
+    bytesread -= (intptr_t)p - (intptr_t)tag;
     tag = p;
 
     while ( bytesread > 0
···
             lrc_line->old_time_start = -1;
             if(is_crlf) p += chsiz;
         }
-        bytesread -= (long)p - (long)tag;
+        bytesread -= (intptr_t)p - (intptr_t)tag;
         tag = p;
         if(!add_lrc_line(lrc_line, utf8line))
             break;
···
 #endif
 
     lrc_buffer = rb->plugin_get_buffer(&lrc_buffer_size);
-    lrc_buffer = (void *)(((long)lrc_buffer+3)&~3); /* 4 bytes aligned */
+    lrc_buffer = ALIGN_UP(lrc_buffer, 4); /* 4 bytes aligned */
     lrc_buffer_size = (lrc_buffer_size - 4)&~3;
 
     reset_current_data();

apps/plugins/mikmod/mikmod_internals.h

···
 
 /*========== SIMD mixing helper functions =============*/
 
-#define IS_ALIGNED_16(ptr) (!(((int)(ptr)) & 15))
+#define IS_ALIGNED_16(ptr) (!(((intptr_t)(ptr)) & 15))
 
 /* Altivec helper function */
 #if defined HAVE_ALTIVEC

apps/plugins/solitaire.c

···
         return -1;
     
     retval = 0; /* Assume good case */
-    if(    ( rb->lseek( fd, -sizeof( int ), SEEK_END ) == -((ssize_t)sizeof( int ))-1 )
+    if(    ( rb->lseek( fd, -(off_t)sizeof( int ), SEEK_END ) == -((ssize_t)sizeof( int ))-1 )
         || ( rb->read( fd, &checksum, sizeof( int ) ) < ((ssize_t)sizeof( int )) )
         || ( rb->lseek( fd, 0, SEEK_SET ) == -1 )
         || save_read( fd, &cur_card, sizeof( int ), &checksum )

apps/plugins/zxbox/snapshot.c

···
     GET_DATA(ch);
     if(p + times > end) {
       put_msg("Warning: Repeat parameter too large in snapshot");
-      times = (int) ((long) end - (long) p);
+      times = (int) ((intptr_t) end - (intptr_t) p);
     }
     for(j = 0; j < times; j++) *p++ = ch;
       }

apps/plugins/zxbox/tapefile.c

···
 };
 
 
-#define PTRDIFF(pe, ps) ((int) (((long) (pe) - (long) (ps)) / sizeof(*pe)))
+#define PTRDIFF(pe, ps) pe - ps
 
 static char tzxheader[] = {'Z','X','T','a','p','e','!',0x1A};
 

apps/plugins/zxbox/z80.c

···
     /*exit(1);*/
   }
 
-  return (byte *) (( (long) bigmem & ~((long) 0xFFFF)) + 0x10000);
+  return (byte *) (( (intptr_t) bigmem & ~((intptr_t) 0xFFFF)) + 0x10000);
 }
 
 

apps/recorder/keyboard.c

···
 
     len = strlen(state->text);
     utf8 = utf8encode(ch, tmp);
-    j = (long)utf8 - (long)tmp;
+    j = (intptr_t)utf8 - (intptr_t)tmp;
 
     if (len + j < state->buflen)
     {

apps/tagcache.c

···
     while (*list)
     {
         sep = strchr(list, '|');
-        l = sep ? (long)sep - (long)list : (int)strlen(list);
+        l = sep ? (intptr_t)sep - (intptr_t)list : (int)strlen(list);
         if ((l==len) && !strncasecmp(str, list, len))
             return true;
         list += sep ? l + 1 : l;
···
                 /* Avoid processing this entry again. */
                 idx.flag |= FLAG_RESURRECTED;
                 
-                lseek(masterfd, -sizeof(struct index_entry), SEEK_CUR);
+                lseek(masterfd, -(off_t)sizeof(struct index_entry), SEEK_CUR);
                 if (ecwrite_index_entry(masterfd, &idx) != sizeof(struct index_entry))
                 {
                     logf("masterfd writeback fail #1");
···
     struct index_entry idx;
     char tag_data[TAG_MAXLEN+32];
     int idx_id;
-    long masterfd = (long)parameters;
+    long masterfd = (long)(intptr_t)parameters;
     const int import_tags[] = { tag_playcount, tag_rating, tag_playtime,
                                 tag_lastplayed, tag_commitid, tag_lastelapsed,
                                 tag_lastoffset };
···
     
     filenametag_fd = open_tag_fd(&tch, tag_filename, false);
     
-    fast_readline(clfd, buf, sizeof buf, (long *)masterfd,
+    fast_readline(clfd, buf, sizeof buf, (void *)(intptr_t)masterfd,
                   parse_changelog_line);
     
     close(clfd);
···
     }
     
     myidx.flag |= FLAG_DELETED;
-    lseek(masterfd, -sizeof(struct index_entry), SEEK_CUR);
+    lseek(masterfd, -(off_t)sizeof(struct index_entry), SEEK_CUR);
     if (ecwrite_index_entry(masterfd, &myidx) != sizeof(struct index_entry))
     {
         logf("delete_entry(): write_error #1");

firmware/asm/memset16.c

···
  ****************************************************************************/
 
 #include "string-extra.h" /* memset16() */
+#include <stdint.h>
 
 #define LBLOCKSIZE (sizeof(long)/2)
-#define ROCKBOX_UNALIGNED(X)   ((long)X & (sizeof(long) - 1))
+#define ROCKBOX_UNALIGNED(X)   ((uintptr_t)X & (sizeof(long) - 1))
 #define TOO_SMALL(LEN) ((LEN) < LBLOCKSIZE)
 
 void memset16(void *dst, int val, size_t len)

firmware/drivers/lcd-16bit-common.c

···
         {
             do
             {
-                memcpy(dst, (void *)((long)dst + lcd_backdrop_offset),
+                memcpy(dst, PTR_ADD(dst, lcd_backdrop_offset),
                        len * sizeof(fb_data));
                 dst += step;
             }
···
 
 static void ICODE_ATTR clearimgpixel(fb_data *address)
 {
-    *address = *(fb_data *)((long)address + lcd_backdrop_offset);
+    *address = *PTR_ADD(address, lcd_backdrop_offset);
 }
 
 static void ICODE_ATTR flippixel(fb_data *address)
···
             break;
 
           case OPT_COPY:
-            memcpy(dst, (void *)((long)dst + lcd_backdrop_offset),
+            memcpy(dst, PTR_ADD(dst, lcd_backdrop_offset),
                    len * sizeof(fb_data));
             break;
 
···
             do
             {
                 if (!(data & 0x01))
-                    *dst = *(fb_data *)((long)dst + bo);
+                    *dst = *PTR_ADD(dst, bo);
 
                 dst += ROW_INC;
                 UPDATE_SRC;
···
             do
             {
                 *dst = (data & 0x01) ? fg
-                           : *(fb_data *)((long)dst + bo);
+                           : *PTR_ADD(dst, bo);
                 dst += ROW_INC;
                 UPDATE_SRC;
             }

firmware/drivers/lcd-16bit.c

···
         break;
 
       case OPT_COPY:
-        memcpy(dst, (void *)((long)dst + lcd_backdrop_offset),
+        memcpy(dst, PTR_ADD(dst, lcd_backdrop_offset),
                width * sizeof(fb_data));
         break;
 

firmware/drivers/lcd-color-common.c

···
     lcd_backdrop = backdrop;
     if (backdrop)
     {
-        lcd_backdrop_offset = (long)backdrop - (long)lcd_framebuffer;
+        lcd_backdrop_offset = (intptr_t)backdrop - (intptr_t)lcd_framebuffer;
         lcd_fastpixelfuncs = lcd_fastpixelfuncs_backdrop;
     }
     else

firmware/kernel/queue.c

···
     wr = q->write++ & QUEUE_LENGTH_MASK;
 
     KERNEL_ASSERT((q->write - q->read) <= QUEUE_LENGTH,
-                  "queue_post ovf q=%08lX", (long)q);
+                  "queue_post ovf q=%p", q);
 
     q->events[wr].id   = id;
     q->events[wr].data = data;
···
     wr = q->write++ & QUEUE_LENGTH_MASK;
 
     KERNEL_ASSERT((q->write - q->read) <= QUEUE_LENGTH,
-                  "queue_send ovf q=%08lX", (long)q);
+                  "queue_send ovf q=%p", q);
 
     q->events[wr].id   = id;
     q->events[wr].data = data;

firmware/target/hosted/filesystem-win32.c

···
     else
     {
         /* Convert OS handle to fd; the fd now owns it */
-        int osfd = _open_osfhandle((long)h, O_RDONLY);
+        int osfd = _open_osfhandle((intptr_t)h, O_RDONLY);
         if (osfd >= 0)
             return osfd;
     }

lib/rbcodec/codecs/liba52/bitstream.c

···
 {
     int align;
 
-    align = (long)buf & 3;
+    align = (intptr_t)buf & 3;
     state->buffer_start = (uint32_t *) (buf - align);
     state->bits_left = 0;
     state->current_word = 0;

lib/rbcodec/codecs/libtremor/codebook.c

···
     if(b->endbyte < b->storage - 8) {
       ogg_uint32_t *ptr;
       unsigned long bit, bitend;
-      unsigned long adr;
+      intptr_t adr;
       ogg_uint32_t cache = 0;
       int cachesize = 0;
       const unsigned int cachemask = (1<<book->dec_firsttablen)-1;
···
       const ogg_uint32_t *book_codelist = book->codelist;
       const char         *book_dec_codelengths = book->dec_codelengths;
 
-      adr = (unsigned long)b->ptr;
+      adr = (intptr_t)b->ptr;
       bit = (adr&3)*8+b->endbit;
       ptr = (ogg_uint32_t*)(adr&~3);
       bitend = ((adr&3)+(b->storage-b->endbyte))*8;
···
         cache >>= l;
       }
 
-      adr=(unsigned long)b->ptr;
+      adr=(intptr_t)b->ptr;
       bit-=(adr&3)*8+cachesize;
       b->endbyte+=bit/8;
       b->ptr+=bit/8;

lib/rbcodec/metadata/id3tags.c

···
             wp++;
         }
     }
-    return (long)wp - (long)tag;
+    return (intptr_t)wp - (intptr_t)tag;
 }
 
 static int unsynchronize_frame(char* tag, int len)
···
             (*len)--;
             utf8 = iso_decode(str, utf8, -1, *len);
             *utf8 = 0;
-            *len = (unsigned long)utf8 - (unsigned long)utf8buf;
+            *len = (intptr_t)utf8 - (intptr_t)utf8buf;
             break;
 
         case 0x01: /* Unicode with or without BOM */
···
         default: /* Plain old string */
             utf8 = iso_decode(str, utf8, -1, *len);
             *utf8 = 0;
-            *len = (unsigned long)utf8 - (unsigned long)utf8buf;
+            *len = (intptr_t)utf8 - (intptr_t)utf8buf;
             break;
     }
     return 0;

lib/tlsf/src/tlsf.c

···
 
 #include <stdio.h>
 #include <string.h>
+#include <stdint.h>
 
 #ifndef TLSF_USE_LOCKS
 #define TLSF_USE_LOCKS  (0)
···
         return -1;
     }
 
-    if (((unsigned long) mem_pool & PTR_MASK)) {
+    if (((intptr_t) mem_pool & PTR_MASK)) {
         ERROR_MSG("init_memory_pool (): mem_pool must be aligned to a word\n");
         return -1;
     }
···
         lb1 = ptr->end;
 
         /* Merging the new area with the next physically contigous one */
-        if ((unsigned long) ib1 == (unsigned long) lb0 + BHDR_OVERHEAD) {
+        if ((uintptr_t) ib1 == (uintptr_t) lb0 + BHDR_OVERHEAD) {
             if (tlsf->area_head == ptr) {
                 tlsf->area_head = ptr->next;
                 ptr = ptr->next;
···
 
         /* Merging the new area with the previous physically contigous
            one */
-        if ((unsigned long) lb1->ptr.buffer == (unsigned long) ib0) {
+        if ((intptr_t) lb1->ptr.buffer == (intptr_t) ib0) {
             if (tlsf->area_head == ptr) {
                 tlsf->area_head = ptr->next;
                 ptr = ptr->next;