Don't force gcc as host compiler + fix clang warnings

On MacOS, gcc is a symlink for clang.

Patch gets rid of the warnings produced by clang,
when it is set as HOSTCC, and fixes voicetools
compilation on MacOS when calling make voicetools
from the simulator directory.

lua rb_defines_helper:
format specifies type 'int' but the argument has
type 'long'

codecs: opus / speex (LOGF):
format '%ld' expects argument of type 'long int',
but argument 7 has type 'off_t'

gigabeat:
variable 'size' set but not used

rdf2binary:
a function declaration without a prototype is
deprecated in all versions of C

rbspeexdec:
passing 'unsigned char *' to parameter of type
'char *' converts between pointers to integer
types where one is of the unique plain 'char'
type and the other is not

hmac-sha1.c
defining a type within 'offsetof' is a Clang
extension

Change-Id: I90539906698868f9589650585d865aee9f7e8539

apps/plugins/lua/rbdefines_helper.pl

···
     }
     elsif(@$define{'value'} =~ /^[0-9]+$/) #number
     {
-        printf "\tprintf(\"%s[\\\"%%s\\\"] = %%d\\n\", stringify(%s), %s);\n", $lua_table, @$define{'name'}, @$define{'name'};
+        printf "\tprintf(\"%s[\\\"%%s\\\"] = %%ld\\n\", stringify(%s), (long) %s);\n", $lua_table, @$define{'name'}, @$define{'name'};
     }
     else #might be a string but we don't know since the macro isn't expanded far enough
     {
···
         }
         elsif ($var =~$num_regex) #it must be a number
         {
-            printf "\tprintf(\"%s[\\\"%%s\\\"] = %%d\\n\", stringify(%s), %s);\n", $lua_table, @$define{'name'}, @$define{'name'};
+            printf "\tprintf(\"%s[\\\"%%s\\\"] = %%ld\\n\", stringify(%s), (long) %s);\n", $lua_table, @$define{'name'}, @$define{'name'};
         }
         else { warn "Skipping ".@$define{'name'}." indeterminate macro type\n"; }
     }

lib/rbcodec/codecs/opus.c

···
                 break;
             if (memcmp(buf, synccode, sizeof(buf)) == 0) {
                 ci->seek_buffer(ci->curpos - sizeof(buf));
-                LOGF("next page %ld", ci->curpos);
+                LOGF("next page %jd", (intmax_t) ci->curpos);
                 return 1;
             } else
                 ci->seek_buffer(ci->curpos - (sizeof(buf) - 1));
···
                 break;
             if (memcmp(buf, synccode, sizeof(buf)) == 0) {
                 ci->seek_buffer(ci->curpos - sizeof(buf));
-                LOGF("OpusTags %ld", ci->curpos);
+                LOGF("OpusTags %jd", (intmax_t) ci->curpos);
                 return 1;
             } else
                 ci->seek_buffer(ci->curpos - (sizeof(buf) - 1));

lib/rbcodec/codecs/speex.c

···
                     offset = ret;
                     continue;
                 }
-            } else if (ret == -3) 
+            } else if (ret == -3)
                 return(-3);
             else if (ret<=0)
                 break;
···
                                    spx_ogg_sync_state *oy,
                                    spx_int64_t headerssize)
 {
-    /* TODO: Someone may want to try to implement seek to packet, 
-             instead of just to page (should be more accurate, not be any 
+    /* TODO: Someone may want to try to implement seek to packet,
+             instead of just to page (should be more accurate, not be any
              faster) */
 
     spx_int64_t crofs;
···
         offset = get_next_page(oy,&og,-1);
 
         if (offset < 0) { /* could not find new page,use old offset */
-            LOGF("Seek/guess/fault:%lld->-<-%d,%lld:%lld,%d,%ld,%d\n",
+            LOGF("Seek/guess/fault:%lld->-<-%d,%lld:%lld,%d,%jd,%d\n",
                   (long long int)curpos,0, (long long int)pos,
-                  (long long int)offset,0,ci->curpos,/*stream_length*/0);
+                  (long long int)offset,0, (intmax_t) ci->curpos,/*stream_length*/0);
 
             curoffset = *curbyteoffset;
 
···
             spx_ogg_sync_reset(oy);
         } else {
             if (spx_ogg_page_granulepos(&og) == 0 && pos > 5000) {
-                LOGF("SEEK/guess/fault:%lld->-<-%lld,%lld:%lld,%d,%ld,%d\n",
+                LOGF("SEEK/guess/fault:%lld->-<-%lld,%lld:%lld,%d,%jd,%d\n",
                      (long long int)curpos,(long long int)spx_ogg_page_granulepos(&og),
-                     (long long int)pos, (long long int)offset,0,ci->curpos,/*stream_length*/0);
+                     (long long int)pos, (long long int)offset,0, (intmax_t) ci->curpos,/*stream_length*/0);
 
                 curoffset = *curbyteoffset;
 
···
 
             lastgranule = spx_ogg_page_granulepos(&og);
 
-            if ( ((lastgranule - (avgpagelen/4)) < pos && ( lastgranule + 
+            if ( ((lastgranule - (avgpagelen/4)) < pos && ( lastgranule +
                   avgpagelen + (avgpagelen / 4)) > pos) ||
                  lastgranule > pos) {
 
···
         DEBUGF("Too old bitstream");
         return NULL;
     }
-   
+
     st = speex_decoder_init(mode);
     if (!st){
         DEBUGF("Decoder init failed");

tools/configure

···
 GLOBAL_LDOPTS=""
 LDMAP_OPT="-Map"
 
-HOSTCC=gcc
-HOSTAR=ar
-
 extradefines=""
 use_logf="#undef ROCKBOX_HAS_LOGF"
 use_bootchart="#undef DO_BOOTCHART"
···
    if $CC --version | grep -q "clang"; then
     echo "[Warning] Clang compiler ($CC) in your path is unsupported. Trying gcc-14."
     CC=gcc-14
-    HOSTCC=gcc-14
     AR=gcc-ar-14
-    HOSTAR=gcc-ar-14
     CPP=cpp-14
    fi
    LDOPTS="$LDOPTS -ldl"
···
 fi
 
 # figure out the full path to the various commands if possible
-HOSTCC=`findtool ${HOSTCC} --lit`
-HOSTAR=`findtool ${HOSTAR} --lit`
+HOSTCC=`findtool gcc --lit`
+HOSTAR=`findtool ar --lit`
 CC=`findtool ${CC} --lit`
 CPP=`findtool ${CPP} --lit`
 LD=`findtool ${LD} --lit`

tools/gigabeat.c

···
 int gigabeat_code(char *infile, char *outfile)
 {
     FILE *in, *out;
-    unsigned long size = 0;
     unsigned long bytes_read;
     unsigned char buf[4];
     unsigned long data;
···
 
         /* Read in little-endian */
         data = le2int(buf);
-        
+
         data = data ^ key;
 
         key = key + (key << 1);
         key = key + 0x19751217;
-
-        size += bytes_read;
 
         /* Write out little-endian */
         int2le(data, buf);

tools/hmac-sha1.c

···
   if (len >= 64)
     {
 #if !_STRING_ARCH_unaligned
-# define alignof(type) offsetof (struct { char c; type x; }, x)
+# define alignof(type) __alignof__(type)
 # define UNALIGNED_P(p) (((size_t) p) % alignof (uint32_t) != 0)
       if (UNALIGNED_P (buffer))
 	while (len > 64)

tools/rbspeex/rbspeexdec.c

···
   * KIND, either express or implied.
   *
   ***************************************************************************/
- 
+
 #include <speex/speex.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include "string.h"
 #include "rbspeex.h"
-  
+
  #define USAGE_TEXT \
 "Usage: rbspeexdec infile outfile\n"\
 "rbspeexdec outputs mono 16 bit 16 kHz WAV files.\n"\
···
 
     /* Rockbox speex streams are always assumed to be WB */
     st = speex_decoder_init(&speex_wb_mode);
- 
+
     /* Set the perceptual enhancement on (is default, but doesn't hurt) */
     tmp = 1;
     speex_decoder_ctl(st, SPEEX_SET_ENH, &tmp);
     speex_decoder_ctl(st, SPEEX_GET_LOOKAHEAD, &lookahead);
     speex_decoder_ctl(st, SPEEX_GET_FRAME_SIZE, &frame_size);
- 
+
     if ((fin = fopen(argv[1], "rb")) == NULL) {
         printf("Error: could not open input file\n");
         return 1;
···
     fclose(fin);
 
     /* fill in wav header */
-    strcpy(wavhdr, "RIFF");
-    strcpy(wavhdr + 8, "WAVEfmt ");
+    strcpy((char *) wavhdr, "RIFF");
+    strcpy((char *) wavhdr + 8, "WAVEfmt ");
     put_uint_le(16, wavhdr + 16);
     put_ushort_le(1, wavhdr + 20);      /* PCM data */
     put_ushort_le(1, wavhdr + 22);      /* mono */
···
     put_uint_le(16000*2, wavhdr + 28);  /* chan*sr*bbs/8 */
     put_ushort_le(2, wavhdr + 32);      /* chan*bps/8 */
     put_ushort_le(16, wavhdr + 34);     /* bits per sample */
-    strcpy(wavhdr + 36, "data");
+    strcpy((char *) wavhdr + 36, "data");
     fwrite(wavhdr, 1, 44, fout);        /* write header */
     /* make bit buffer use our own buffer */
     speex_bits_set_bit_buffer(&bits, indata, insize);

tools/rdf2binary.c

···
 }
 
 
-int main()
+int main(void)
 {
     FILE *in, *idx_out, *desc_out;
     struct word w;