tsiry-sandratraina.com
A modern Music Player Daemon based on Rockbox open source high quality audio player
libadwaita
audio
rust
zig
deno
mpris
rockbox
mpd
ErosQ (both): avoid clipping due to DC offset bandaid
Set the maximum volume on both hosted and native ports
to -2 dB.
Verified behavior here on native and by borkitall on irc
for hosted.
Change-Id: I3aebc2bb4b9294a4137a33694c83139c0d76099a
+16
-3
+8
-2
firmware/export/eros_qn_codec.h
+8
-2
firmware/export/eros_qn_codec.h
···
23
23
#ifndef _EROS_QN_CODEC_H
24
24
#define _EROS_QN_CODEC_H
25
25
26
+
/*
27
+
* Note: Maximum volume is set one step below unity in order to
28
+
* avoid overflowing pcm samples due to our DC Offset.
29
+
*
30
+
* The DAC's output is hot enough this should not be an issue.
31
+
*/
26
32
#define PCM5102A_VOLUME_MIN -740
27
-
#define PCM5102A_VOLUME_MAX 0
33
+
#define PCM5102A_VOLUME_MAX -20
28
34
29
-
/* a small DC offset appears to prevent play/pause clicking */
35
+
/* a small DC offset prevents play/pause clicking due to the DAC auto-muting */
30
36
#define PCM_DC_OFFSET_VALUE -1
31
37
32
38
AUDIOHW_SETTING(VOLUME, "dB", 0, 2, PCM5102A_VOLUME_MIN/10, PCM5102A_VOLUME_MAX/10, 0)
+8
-1
firmware/export/erosqlinux_codec.h
+8
-1
firmware/export/erosqlinux_codec.h
···
3
3
4
4
#define AUDIOHW_CAPS (LINEOUT_CAP)
5
5
6
+
/* a small DC offset prevents play/pause clicking due to the DAC auto-muting */
6
7
#define PCM_DC_OFFSET_VALUE -1
7
8
8
-
AUDIOHW_SETTING(VOLUME, "dB", 0, 2, -74, 0, -40)
9
+
/*
10
+
* Note: Maximum volume is set one step below unity in order to
11
+
* avoid overflowing pcm samples due to our DC Offset.
12
+
*
13
+
* The DAC's output is hot enough this should not be an issue.
14
+
*/
15
+
AUDIOHW_SETTING(VOLUME, "dB", 0, 2, -74, -2, -40)
9
16
10
17
//#define AUDIOHW_NEEDS_INITIAL_UNMUTE
11
18