use strict variable expansion and don't provide defaults

Signed-off-by: tjh <did:plc:65gha4t3avpfpzmvpbwovss7>

src/README.md.sh

···
 #!/usr/bin/bash
+set -eu
 cat << EOF > ${pkgbuild_path}/README.md
 # pkgs
 

src/knotserver-git/README.md.sh

···
 #!/usr/bin/bash
+set -eu
 cat << EOF > ${pkgbuild_path}/README.md
 # knotserver-git
 
···
 ## SSH
 
 SSH access is required to push to repositories. To enable, use the sshd_config.d drop-in, and give the
-\`${knotserver_user:-git}\` user a shell and a home directory:
+\`${knotserver_user}\` user a shell and a home directory:
 
 \`\`\`bash
 ln -s /usr/lib/systemd/sshd_config.d/knotserver.conf /etc/ssh/sshd_config.d/30-knotserver.conf
-usermod -s /usr/bin/bash -d ${knotserver_repo_path} ${knotserver_user:-git}
+usermod -s /usr/bin/bash -d ${knotserver_repo_path} ${knotserver_user}
 \`\`\`
 
 EOF

src/knotserver-shared/install.sh

···
 #!/usr/bin/bash
+set -eu
 cat << EOF > ${pkgbuild_path}/knotserver.install
 post_install() {
   echo
-  echo knotserver installed, with repositories stored in: ${knotserver_repo_path:-/var/lib/tangled/repositories}
+  echo knotserver installed, with repositories stored in: ${knotserver_repo_path}
   echo
   echo Use "systemctl edit knotserver.service" to set "KNOT_SERVER_OWNER" to the DID of the knot owner,
   echo and override "KNOT_SERVER_HOSTNAME" if 'hostname' does not return the FQDN echo of your knot.
   echo
   echo To enable git push over ssh for tangled repositories, run:
   echo "  ln -s /usr/lib/systemd/sshd_config.d/knotserver.conf /etc/ssh/sshd_config.d/30-knotserver.conf"
-  echo "  usermod -s /usr/bin/bash -d ${knotserver_repo_path:-/var/lib/tangled/repositories} ${knotserver_user:-git}"
+  echo "  usermod -s /usr/bin/bash -d ${knotserver_repo_path} ${knotserver_user}"
   echo
   echo and reload sshd
   echo

src/knotserver-shared/service.sh

···
 #!/usr/bin/bash
+set -eu
 cat << EOF > ${pkgbuild_path}/knotserver.service
 [Unit]
 Description=tangled knot server
 After=network.target network-online.target
 Wants=network-online.target
-AssertPathExists=${knotserver_path:-/var/lib/tangled}
-AssertPathExists=${knotserver_repo_path:-/var/lib/tangled/repositories}
+AssertPathExists=${knotserver_path}
+AssertPathExists=${knotserver_repo_path}
 
 [Service]
 Environment="KNOT_SERVER_HOSTNAME=%H"
 Environment="KNOT_SERVER_LISTEN_ADDR=127.0.0.1:5555"
-Environment="KNOT_REPO_SCAN_PATH=${knotserver_repo_path:-/var/lib/tangled/repositories}"
-WorkingDirectory=${knotserver_path:-/var/lib/tangled}
+Environment="KNOT_REPO_SCAN_PATH=${knotserver_repo_path}"
+WorkingDirectory=${knotserver_path}
 ExecStart=/usr/bin/knot server
 Restart=always
-User=${knotserver_user:-git}
-Group=${knotserver_group:-git}
+User=${knotserver_user}
+Group=${knotserver_group}
 
 StandardOutput=journal
 StandardError=journal

src/knotserver-shared/sshd.conf.sh

···
 #!/usr/bin/bash
+set -eu
 cat << EOF > ${pkgbuild_path}/knotserver-sshd.conf
-Match User ${knotserver_user:-git}
-  AuthorizedKeysCommand /usr/bin/knot keys -output authorized-keys -git-dir ${knotserver_repo_path:-/var/lib/tangled/repositories} -log-path ${knotserver_log_directory:-/var/log/knotserver}/keyfetch.log
+Match User ${knotserver_user}
+  AuthorizedKeysCommand /usr/bin/knot keys -output authorized-keys -git-dir ${knotserver_repo_path} -log-path ${knotserver_log_directory}/keyfetch.log
   AuthorizedKeysCommandUser nobody
 EOF

src/knotserver-shared/tmpfiles.conf.sh

···
 #!/usr/bin/bash
+set -eu
 cat << EOF > ${pkgbuild_path}/knotserver-tmpfiles.conf
 d /etc/tangled 700 root root
-d ${knotserver_path:-/var/lib/tangled} 755 ${knotserver_user:-git} ${knotserver_group:-git} -
-d ${knotserver_repo_path:-/var/lib/tangled/repositories} 755 ${knotserver_user:-git} ${knotserver_group:-git} -
+d ${knotserver_path} 755 ${knotserver_user} ${knotserver_group} -
+d ${knotserver_repo_path} 755 ${knotserver_user} ${knotserver_group} -
 EOF

src/knotserver/PKGBUILD.sh

···
 #!/usr/bin/bash
+set -eu
 cat << EOF > ${pkgbuild_path}/PKGBUILD
 _pkgname=knotserver
 _pkgver=${tag}

src/knotserver/README.md.sh

···
 #!/usr/bin/bash
+set -eu
 cat << EOF > ${pkgbuild_path}/README.md
 # knotserver
 
···
 ## SSH
 
 SSH access is required to push to repositories. To enable, use the sshd_config.d drop-in, and give the
-\`${knotserver_user:-git}\` user a shell and a home directory:
+\`${knotserver_user}\` user a shell and a home directory:
 
 \`\`\`bash
 ln -s /usr/lib/systemd/sshd_config.d/knotserver.conf /etc/ssh/sshd_config.d/30-knotserver.conf
-usermod -s /usr/bin/bash -d ${knotserver_repo_path} ${knotserver_user:-git}
+usermod -s /usr/bin/bash -d ${knotserver_repo_path} ${knotserver_user}
 \`\`\`
 
 EOF

src/spindle/PKGBUILD.sh

···
 #!/usr/bin/bash
+set -eu
 cat << EOF > ${pkgbuild_path}/PKGBUILD
 _pkgname=spindle
 _pkgver=${tag}

src/spindle/service.sh

···
 #!/usr/bin/bash
+set -eu
 cat << EOF > ${pkgbuild_path}/spindle.service
 [Unit]
 Description=tangled spindle server
 After=network.target network-online.target docker.service
 Wants=network-online.target
-AssertPathExists=${spindle_path:-/var/lib/spindle}
+AssertPathExists=${spindle_path}
 
 [Service]
 Environment="SPINDLE_SERVER_HOSTNAME=%H"
 Environment="SPINDLE_SERVER_LISTEN_ADDR=127.0.0.1:6555"
-WorkingDirectory=${spindle_path:-/var/lib/spindle}
+WorkingDirectory=${spindle_path}
 ExecStart=/usr/bin/spindle
 Restart=always
-User=${spindle_user:-root}
-Group=${spindle_group:-root}
+User=${spindle_user}
+Group=${spindle_group}
 StandardOutput=journal
 StandardError=journal
 LimitNOFILE=65536

src/spindle/tmpfiles.conf.sh

···
 #!/usr/bin/bash
+set -eu
 cat << EOF > ${pkgbuild_path}/spindle-tmpfiles.conf
-d ${spindle_path:-/var/lib/tangled} 755 ${spindle_user:-root} ${spindle_group:-root} -
+d ${spindle_path} 755 ${spindle_user} ${spindle_group} -
 EOF

update.sh

···
 #!/usr/bin/env bash
+set -eu
 
 source ./conf.sh