Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

regmap: Fix debugfs-file 'registers' mode

The macro "REGMAP_ALLOW_WRITE_DEBUGFS" can be used to enable write
support on the registers file in the debugfs. The mode of the file is
fixed to 0400 so it is not possible to write the file ever.

This patch fixes the mode by setting it to the correct value depending
on the macro.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Markus Pargmann and committed by
Mark Brown
ffff7a12 7d1311b9

+8 -1
+8 -1
drivers/base/regmap/regmap-debugfs.c
··· 512 512 map, &regmap_reg_ranges_fops); 513 513 514 514 if (map->max_register || regmap_readable(map, 0)) { 515 - debugfs_create_file("registers", 0400, map->debugfs, 515 + umode_t registers_mode; 516 + 517 + if (IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS)) 518 + registers_mode = 0600; 519 + else 520 + registers_mode = 0400; 521 + 522 + debugfs_create_file("registers", registers_mode, map->debugfs, 516 523 map, &regmap_map_fops); 517 524 debugfs_create_file("access", 0400, map->debugfs, 518 525 map, &regmap_access_fops);