Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ipv6: anycast: use call_rcu_hurry() in aca_put()

This is a followup of commit b5327b9a300e ("ipv6: use
call_rcu_hurry() in fib6_info_release()").

I had another pmtu.sh failure, and found another lazy
call_rcu() causing this failure.

aca_free_rcu() calls fib6_info_release() which releases
devices references.

We must not delay it too much or risk unregister_netdevice/ref_tracker
traces because references to netdev are not released in time.

This should speedup device/netns dismantles when CONFIG_RCU_LAZY=y

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Eric Dumazet and committed by
David S. Miller
fff6e6ac c2e6a872

+2 -3
+2 -3
net/ipv6/anycast.c
··· 252 252 253 253 static void aca_put(struct ifacaddr6 *ac) 254 254 { 255 - if (refcount_dec_and_test(&ac->aca_refcnt)) { 256 - call_rcu(&ac->rcu, aca_free_rcu); 257 - } 255 + if (refcount_dec_and_test(&ac->aca_refcnt)) 256 + call_rcu_hurry(&ac->rcu, aca_free_rcu); 258 257 } 259 258 260 259 static struct ifacaddr6 *aca_alloc(struct fib6_info *f6i,