binfmt_misc: fix false -ENOEXEC when coupled with other binary handlers

In case the binfmt_misc binary handler is registered *before* the e.g.
script one (when for example being compiled as a module) the following
situation may occur:

1. user launches a script, whose interpreter is a misc binary;
2. the load_misc_binary sets the misc_bang and returns -ENOEVEC,
since the binary is a script;
3. the load_script_binary loads one and calls for search_binary_hander
to run the interpreter;
4. the load_misc_binary is called again, but refuses to load the
binary due to misc_bang bit set.

The fix is to move the misc_bang setting lower - prior to the actual
call to the search_binary_handler.

Caused by the commit 3a2e7f47 (binfmt_misc.c: avoid potential kernel
stack overflow)

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Reported-by: Kirill A. Shutemov <kirill@shutemov.name>
Tested-by: Kirill A. Shutemov <kirill@shutemov.name>
Cc: <stable@kernel.org> [2.6.26.x]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by Pavel Emelyanov and committed by Linus Torvalds ff9bc512 c82f2966

+2 -2
+2 -2
fs/binfmt_misc.c
··· 120 120 if (bprm->misc_bang) 121 121 goto _ret; 122 122 123 - bprm->misc_bang = 1; 124 - 125 123 /* to keep locking time low, we copy the interpreter string */ 126 124 read_lock(&entries_lock); 127 125 fmt = check_file(bprm); ··· 196 198 197 199 if (retval < 0) 198 200 goto _error; 201 + 202 + bprm->misc_bang = 1; 199 203 200 204 retval = search_binary_handler (bprm, regs); 201 205 if (retval < 0)