Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

x86: Use __builtin_memset and __builtin_memcpy for memset/memcpy

GCC provides reasonable memset/memcpy functions itself, with __builtin_memset
and __builtin_memcpy. For the "unknown" cases, it'll fall back to our
current existing functions, but for fixed size versions it'll inline
something smart. Quite often that will be the same as we have now,
but sometimes it can do something smarter (for example, if the code
then sets the first member of a struct, it can do a shorter memset).

In addition, and this is more important, gcc knows which registers and
such are not clobbered (while for our asm version it pretty much
acts like a compiler barrier), so for various cases it can avoid reloading
values.

The effect on codesize is shown below on my typical laptop .config:

text data bss dec hex filename
5605675 2041100 6525148 14171923 d83f13 vmlinux.before
5595849 2041668 6525148 14162665 d81ae9 vmlinux.after

Due to some not-so-good behavior in the gcc 3.x series, this change
is only done for GCC 4.x and above.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
LKML-Reference: <20090928142122.6fc57e9c@infradead.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>

authored by

Arjan van de Ven and committed by
H. Peter Anvin
ff60fab7 9f0cf4ad

+9
+9
arch/x86/include/asm/string_32.h
··· 177 177 */ 178 178 179 179 #ifndef CONFIG_KMEMCHECK 180 + 181 + #if (__GNUC__ >= 4) 182 + #define memcpy(t, f, n) __builtin_memcpy(t, f, n) 183 + #else 180 184 #define memcpy(t, f, n) \ 181 185 (__builtin_constant_p((n)) \ 182 186 ? __constant_memcpy((t), (f), (n)) \ 183 187 : __memcpy((t), (f), (n))) 188 + #endif 184 189 #else 185 190 /* 186 191 * kmemcheck becomes very happy if we use the REP instructions unconditionally, ··· 321 316 : __memset_generic((s), (c), (count))) 322 317 323 318 #define __HAVE_ARCH_MEMSET 319 + #if (__GNUC__ >= 4) 320 + #define memset(s, c, count) __builtin_memset(s, c, count) 321 + #else 324 322 #define memset(s, c, count) \ 325 323 (__builtin_constant_p(c) \ 326 324 ? __constant_c_x_memset((s), (0x01010101UL * (unsigned char)(c)), \ 327 325 (count)) \ 328 326 : __memset((s), (c), (count))) 327 + #endif 329 328 330 329 /* 331 330 * find the first occurrence of byte 'c', or 1 past the area if none