Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] gspca - sn9c20x: Cleanup source

- copyright change
- use the kbuild module name for messages
- remove useless code
- add/remove blank lines, parenthesis, braces
- add/change some information messages

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

authored by

Jean-François Moine and committed by
Mauro Carvalho Chehab
ff38d58e ccbaba43

+32 -28
+32 -28
drivers/media/video/gspca/sn9c20x.c
··· 1 1 /* 2 2 * Sonix sn9c201 sn9c202 library 3 + * 4 + * Copyright (C) 2012 Jean-Francois Moine <http://moinejf.free.fr> 3 5 * Copyright (C) 2008-2009 microdia project <microdia@googlegroups.com> 4 6 * Copyright (C) 2009 Brian Johnson <brijohn@gmail.com> 5 7 * ··· 34 32 "microdia project <microdia@googlegroups.com>"); 35 33 MODULE_DESCRIPTION("GSPCA/SN9C20X USB Camera Driver"); 36 34 MODULE_LICENSE("GPL"); 37 - 38 - #define MODULE_NAME "sn9c20x" 39 35 40 36 /* 41 37 * Pixel format private data ··· 1133 1133 1134 1134 static void reg_w1(struct gspca_dev *gspca_dev, u16 reg, const u8 value) 1135 1135 { 1136 - u8 data[1] = {value}; 1137 - reg_w(gspca_dev, reg, data, 1); 1136 + reg_w(gspca_dev, reg, &value, 1); 1138 1137 } 1139 1138 1140 1139 static void i2c_w(struct gspca_dev *gspca_dev, const u8 *buffer) 1141 1140 { 1142 1141 int i; 1142 + 1143 1143 reg_w(gspca_dev, 0x10c0, buffer, 8); 1144 1144 for (i = 0; i < 5; i++) { 1145 1145 reg_r(gspca_dev, 0x10c0, 1); ··· 1161 1161 static void i2c_w1(struct gspca_dev *gspca_dev, u8 reg, u8 val) 1162 1162 { 1163 1163 struct sd *sd = (struct sd *) gspca_dev; 1164 - 1165 1164 u8 row[8]; 1166 1165 1167 1166 /* ··· 1200 1201 row[0] = 0x81 | (3 << 4); 1201 1202 row[1] = sd->i2c_addr; 1202 1203 row[2] = reg; 1203 - row[3] = (val >> 8) & 0xff; 1204 - row[4] = val & 0xff; 1204 + row[3] = val >> 8; 1205 + row[4] = val; 1205 1206 row[5] = 0x00; 1206 1207 row[6] = 0x00; 1207 1208 row[7] = 0x10; ··· 1586 1587 if (vflip) { 1587 1588 value |= 0x10; 1588 1589 sd->vstart = 2; 1589 - } else 1590 + } else { 1590 1591 sd->vstart = 3; 1592 + } 1591 1593 reg_w1(gspca_dev, 0x1182, sd->vstart); 1592 1594 i2c_w1(gspca_dev, 0x1e, value); 1593 1595 break; ··· 1741 1741 struct v4l2_dbg_register *reg) 1742 1742 { 1743 1743 struct sd *sd = (struct sd *) gspca_dev; 1744 + 1744 1745 switch (reg->match.type) { 1745 1746 case V4L2_CHIP_MATCH_HOST: 1746 1747 if (reg->match.addr != 0) ··· 1769 1768 struct v4l2_dbg_register *reg) 1770 1769 { 1771 1770 struct sd *sd = (struct sd *) gspca_dev; 1771 + 1772 1772 switch (reg->match.type) { 1773 1773 case V4L2_CHIP_MATCH_HOST: 1774 1774 if (reg->match.addr != 0) ··· 1824 1822 cam = &gspca_dev->cam; 1825 1823 cam->needs_full_bandwidth = 1; 1826 1824 1827 - sd->sensor = (id->driver_info >> 8) & 0xff; 1828 - sd->i2c_addr = id->driver_info & 0xff; 1829 - sd->flags = (id->driver_info >> 16) & 0xff; 1825 + sd->sensor = id->driver_info >> 8; 1826 + sd->i2c_addr = id->driver_info; 1827 + sd->flags = id->driver_info >> 16; 1830 1828 1831 1829 switch (sd->sensor) { 1832 1830 case SENSOR_MT9M112: ··· 1920 1918 mt9v_init_sensor(gspca_dev); 1921 1919 if (gspca_dev->usb_err < 0) 1922 1920 break; 1921 + pr_info("MT9VPRB sensor detected\n"); 1923 1922 break; 1924 1923 case SENSOR_MT9M111: 1925 1924 mt9m111_init_sensor(gspca_dev); ··· 1946 1943 pr_info("HV7131R sensor detected\n"); 1947 1944 break; 1948 1945 default: 1949 - pr_info("Unsupported Sensor\n"); 1946 + pr_err("Unsupported sensor\n"); 1950 1947 gspca_dev->usb_err = -ENODEV; 1951 1948 } 1952 1949 ··· 1957 1954 { 1958 1955 struct sd *sd = (struct sd *) gspca_dev; 1959 1956 u8 value; 1957 + 1960 1958 switch (sd->sensor) { 1961 1959 case SENSOR_SOI968: 1962 1960 if (mode & MODE_SXGA) { ··· 2040 2036 break; 2041 2037 default: /* >= 640x480 */ 2042 2038 gspca_dev->alt = 9; 2039 + break; 2043 2040 } 2044 2041 } 2045 2042 ··· 2247 2242 int len) /* interrupt packet length */ 2248 2243 { 2249 2244 struct sd *sd = (struct sd *) gspca_dev; 2250 - int ret = -EINVAL; 2245 + 2251 2246 if (!(sd->flags & HAS_NO_BUTTON) && len == 1) { 2252 - input_report_key(gspca_dev->input_dev, KEY_CAMERA, 1); 2253 - input_sync(gspca_dev->input_dev); 2254 - input_report_key(gspca_dev->input_dev, KEY_CAMERA, 0); 2255 - input_sync(gspca_dev->input_dev); 2256 - ret = 0; 2247 + input_report_key(gspca_dev->input_dev, KEY_CAMERA, 1); 2248 + input_sync(gspca_dev->input_dev); 2249 + input_report_key(gspca_dev->input_dev, KEY_CAMERA, 0); 2250 + input_sync(gspca_dev->input_dev); 2251 + return 0; 2257 2252 } 2258 - return ret; 2253 + return -EINVAL; 2259 2254 } 2260 2255 #endif 2261 2256 ··· 2308 2303 int len) /* iso packet length */ 2309 2304 { 2310 2305 struct sd *sd = (struct sd *) gspca_dev; 2311 - int avg_lum; 2306 + int avg_lum, is_jpeg; 2312 2307 static u8 frame_header[] = 2313 2308 {0xff, 0xff, 0x00, 0xc4, 0xc4, 0x96}; 2309 + 2310 + is_jpeg = (sd->fmt & 0x03) == 0; 2314 2311 if (len >= 64 && memcmp(data, frame_header, 6) == 0) { 2315 2312 avg_lum = ((data[35] >> 2) & 3) | 2316 2313 (data[20] << 2) | ··· 2341 2334 avg_lum >>= 9; 2342 2335 atomic_set(&sd->avg_lum, avg_lum); 2343 2336 2344 - if (gspca_dev->cam.cam_mode[(int) gspca_dev->curr_mode].priv 2345 - & MODE_JPEG) 2337 + if (is_jpeg) 2346 2338 transfer_check(gspca_dev, data); 2347 2339 2348 2340 gspca_frame_add(gspca_dev, LAST_PACKET, NULL, 0); ··· 2351 2345 data += 64; 2352 2346 } 2353 2347 if (gspca_dev->last_packet_type == LAST_PACKET) { 2354 - if (gspca_dev->cam.cam_mode[(int) gspca_dev->curr_mode].priv 2355 - & MODE_JPEG) { 2348 + if (is_jpeg) { 2356 2349 gspca_frame_add(gspca_dev, FIRST_PACKET, 2357 2350 sd->jpeg_hdr, JPEG_HDR_SZ); 2358 2351 gspca_frame_add(gspca_dev, INTER_PACKET, ··· 2362 2357 } 2363 2358 } else { 2364 2359 /* if JPEG, count the packets and their size */ 2365 - if (gspca_dev->cam.cam_mode[(int) gspca_dev->curr_mode].priv 2366 - & MODE_JPEG) { 2360 + if (is_jpeg) { 2367 2361 sd->npkt++; 2368 2362 sd->pktsz += len; 2369 2363 } ··· 2372 2368 2373 2369 /* sub-driver description */ 2374 2370 static const struct sd_desc sd_desc = { 2375 - .name = MODULE_NAME, 2371 + .name = KBUILD_MODNAME, 2376 2372 .ctrls = sd_ctrls, 2377 2373 .nctrls = ARRAY_SIZE(sd_ctrls), 2378 2374 .config = sd_config, ··· 2449 2445 } 2450 2446 2451 2447 static struct usb_driver sd_driver = { 2452 - .name = MODULE_NAME, 2448 + .name = KBUILD_MODNAME, 2453 2449 .id_table = device_table, 2454 2450 .probe = sd_probe, 2455 2451 .disconnect = gspca_disconnect,