Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

video: fbdev: atmel_lcdfb: fix an error code in atmel_lcdfb_probe()

If "sinfo->config" is not found, then return -ENODEV. Don't
return success.

Fixes: b985172b328a ("video: atmel_lcdfb: add device tree suport")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Helge Deller <deller@gmx.de>

authored by

Dan Carpenter and committed by
Helge Deller
fee5c1e4 0f8a1cae

+6 -5
+6 -5
drivers/video/fbdev/atmel_lcdfb.c
··· 1062 1062 1063 1063 INIT_LIST_HEAD(&info->modelist); 1064 1064 1065 - if (pdev->dev.of_node) { 1066 - ret = atmel_lcdfb_of_init(sinfo); 1067 - if (ret) 1068 - goto free_info; 1069 - } else { 1065 + if (!pdev->dev.of_node) { 1070 1066 dev_err(dev, "cannot get default configuration\n"); 1071 1067 goto free_info; 1072 1068 } 1073 1069 1070 + ret = atmel_lcdfb_of_init(sinfo); 1071 + if (ret) 1072 + goto free_info; 1073 + 1074 + ret = -ENODEV; 1074 1075 if (!sinfo->config) 1075 1076 goto free_info; 1076 1077