Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: dac: ltc2688: Use temporary variable for struct device

Use temporary variable for struct device to make code neater.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20220302153142.52743-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Andy Shevchenko and committed by
Jonathan Cameron
fee4ac32 8a7449d6

+9 -10
+9 -10
drivers/iio/dac/ltc2688.c
··· 703 703 struct ltc2688_chan *chan, 704 704 struct fwnode_handle *node, int tgp) 705 705 { 706 + struct device *dev = &st->spi->dev; 706 707 unsigned long rate; 707 708 struct clk *clk; 708 709 int ret, f; 709 710 710 - clk = devm_get_clk_from_child(&st->spi->dev, to_of_node(node), NULL); 711 + clk = devm_get_clk_from_child(dev, to_of_node(node), NULL); 711 712 if (IS_ERR(clk)) 712 - return dev_err_probe(&st->spi->dev, PTR_ERR(clk), 713 - "failed to get tgp clk.\n"); 713 + return dev_err_probe(dev, PTR_ERR(clk), "failed to get tgp clk.\n"); 714 714 715 715 ret = clk_prepare_enable(clk); 716 716 if (ret) 717 - return dev_err_probe(&st->spi->dev, ret, 718 - "failed to enable tgp clk.\n"); 717 + return dev_err_probe(dev, ret, "failed to enable tgp clk.\n"); 719 718 720 - ret = devm_add_action_or_reset(&st->spi->dev, ltc2688_clk_disable, clk); 719 + ret = devm_add_action_or_reset(dev, ltc2688_clk_disable, clk); 721 720 if (ret) 722 721 return ret; 723 722 ··· 857 858 858 859 static int ltc2688_setup(struct ltc2688_state *st, struct regulator *vref) 859 860 { 861 + struct device *dev = &st->spi->dev; 860 862 struct gpio_desc *gpio; 861 863 int ret; 862 864 ··· 865 865 * If we have a reset pin, use that to reset the board, If not, use 866 866 * the reset bit. 867 867 */ 868 - gpio = devm_gpiod_get_optional(&st->spi->dev, "clr", GPIOD_OUT_HIGH); 868 + gpio = devm_gpiod_get_optional(dev, "clr", GPIOD_OUT_HIGH); 869 869 if (IS_ERR(gpio)) 870 - return dev_err_probe(&st->spi->dev, PTR_ERR(gpio), 871 - "Failed to get reset gpio"); 870 + return dev_err_probe(dev, PTR_ERR(gpio), "Failed to get reset gpio"); 872 871 if (gpio) { 873 872 usleep_range(1000, 1200); 874 873 /* bring device out of reset */ ··· 886 887 * Duplicate the default channel configuration as it can change during 887 888 * @ltc2688_channel_config() 888 889 */ 889 - st->iio_chan = devm_kmemdup(&st->spi->dev, ltc2688_channels, 890 + st->iio_chan = devm_kmemdup(dev, ltc2688_channels, 890 891 sizeof(ltc2688_channels), GFP_KERNEL); 891 892 if (!st->iio_chan) 892 893 return -ENOMEM;