Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tty: ipwireless, cleanup TIOCGSERIAL

In ipwireless_get_serial_info, struct serial_struct is memset to 0 and
then some members set to 0 explicitly.

Remove the latter as it is obviously superfluous.

And remove the retinfo check against NULL. copy_to_user will take care
of that.

Part of hub6 cleanup series.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Jiri Kosina <jikos@kernel.org>
Acked-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Jiri Slaby and committed by
Greg Kroah-Hartman
fec4daec 33688abb

+1 -10
+1 -10
drivers/tty/ipwireless/tty.c
··· 252 252 { 253 253 struct serial_struct tmp; 254 254 255 - if (!retinfo) 256 - return (-EFAULT); 257 - 258 255 memset(&tmp, 0, sizeof(tmp)); 259 256 tmp.type = PORT_UNKNOWN; 260 257 tmp.line = tty->index; 261 - tmp.port = 0; 262 - tmp.irq = 0; 263 - tmp.flags = 0; 264 258 tmp.baud_base = 115200; 265 - tmp.close_delay = 0; 266 - tmp.closing_wait = 0; 267 - tmp.custom_divisor = 0; 268 - tmp.hub6 = 0; 259 + 269 260 if (copy_to_user(retinfo, &tmp, sizeof(*retinfo))) 270 261 return -EFAULT; 271 262