Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwspinlock: Remove unused hwspin_lock_get_id()

hwspin_lock_get_id() has been unused since the original 2011
commit bd9a4c7df256 ("drivers: hwspinlock: add framework")

Remove it and the corresponding docs.

Note that the of_hwspin_lock_get_id() version is still in use,
so leave that alone.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Link: https://lore.kernel.org/r/20241215022023.181435-1-linux@treblig.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>

authored by

Dr. David Alan Gilbert and committed by
Bjorn Andersson
fec04edb e9a3682d

-34
-11
Documentation/locking/hwspinlock.rst
··· 301 301 Doing so is considered a bug (there is no protection against this). 302 302 This function will never sleep. 303 303 304 - :: 305 - 306 - int hwspin_lock_get_id(struct hwspinlock *hwlock); 307 - 308 - Retrieve id number of a given hwspinlock. This is needed when an 309 - hwspinlock is dynamically assigned: before it can be used to achieve 310 - mutual exclusion with a remote cpu, the id number should be communicated 311 - to the remote task with which we want to synchronize. 312 - 313 - Returns the hwspinlock id number, or -EINVAL if hwlock is null. 314 - 315 304 Typical usage 316 305 ============= 317 306
-17
drivers/hwspinlock/hwspinlock_core.c
··· 710 710 } 711 711 712 712 /** 713 - * hwspin_lock_get_id() - retrieve id number of a given hwspinlock 714 - * @hwlock: a valid hwspinlock instance 715 - * 716 - * Returns: the id number of a given @hwlock, or -EINVAL if @hwlock is invalid. 717 - */ 718 - int hwspin_lock_get_id(struct hwspinlock *hwlock) 719 - { 720 - if (!hwlock) { 721 - pr_err("invalid hwlock\n"); 722 - return -EINVAL; 723 - } 724 - 725 - return hwlock_to_id(hwlock); 726 - } 727 - EXPORT_SYMBOL_GPL(hwspin_lock_get_id); 728 - 729 - /** 730 713 * hwspin_lock_request_specific() - request for a specific hwspinlock 731 714 * @id: index of the specific hwspinlock that is requested 732 715 *
-6
include/linux/hwspinlock.h
··· 61 61 struct hwspinlock *hwspin_lock_request_specific(unsigned int id); 62 62 int hwspin_lock_free(struct hwspinlock *hwlock); 63 63 int of_hwspin_lock_get_id(struct device_node *np, int index); 64 - int hwspin_lock_get_id(struct hwspinlock *hwlock); 65 64 int __hwspin_lock_timeout(struct hwspinlock *, unsigned int, int, 66 65 unsigned long *); 67 66 int __hwspin_trylock(struct hwspinlock *, int, unsigned long *); ··· 126 127 } 127 128 128 129 static inline int of_hwspin_lock_get_id(struct device_node *np, int index) 129 - { 130 - return 0; 131 - } 132 - 133 - static inline int hwspin_lock_get_id(struct hwspinlock *hwlock) 134 130 { 135 131 return 0; 136 132 }