Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PCI: hv: Return zero, not garbage, when reading PCI_INTERRUPT_PIN

The intent of the code snippet is to always return 0 for both
PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN.

The check misses PCI_INTERRUPT_PIN. This patch fixes that.

This is discovered by this call in VFIO:

pci_read_config_byte(vdev->pdev, PCI_INTERRUPT_PIN, &pin);

The old code does not set *val to 0 because it misses the check for
PCI_INTERRUPT_PIN. Garbage is returned in that case.

Fixes: 4daace0d8ce8 ("PCI: hv: Add paravirtual PCI front-end for Microsoft Hyper-V VMs")
Link: https://lore.kernel.org/linux-pci/20240701202606.129606-1-wei.liu@kernel.org
Signed-off-by: Wei Liu <wei.liu@kernel.org>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: Michael Kelley <mhklinux@outlook.com>
Cc: stable@kernel.org

authored by

Wei Liu and committed by
Krzysztof Wilczyński
fea93a3e 1613e604

+2 -2
+2 -2
drivers/pci/controller/pci-hyperv.c
··· 1130 1130 PCI_CAPABILITY_LIST) { 1131 1131 /* ROM BARs are unimplemented */ 1132 1132 *val = 0; 1133 - } else if (where >= PCI_INTERRUPT_LINE && where + size <= 1134 - PCI_INTERRUPT_PIN) { 1133 + } else if ((where >= PCI_INTERRUPT_LINE && where + size <= PCI_INTERRUPT_PIN) || 1134 + (where >= PCI_INTERRUPT_PIN && where + size <= PCI_MIN_GNT)) { 1135 1135 /* 1136 1136 * Interrupt Line and Interrupt PIN are hard-wired to zero 1137 1137 * because this front-end only supports message-signaled