Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rtc: Fix offset calculation for .start_secs < 0

The comparison

rtc->start_secs > rtc->range_max

has a signed left-hand side and an unsigned right-hand side.
So the comparison might become true for negative start_secs which is
interpreted as a (possibly very large) positive value.

As a negative value can never be bigger than an unsigned value
the correct representation of the (mathematical) comparison

rtc->start_secs > rtc->range_max

in C is:

rtc->start_secs >= 0 && rtc->start_secs > rtc->range_max

Use that to fix the offset calculation currently used in the
rtc-mt6397 driver.

Fixes: 989515647e783 ("rtc: Add one offset seconds to expand RTC range")
Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://lore.kernel.org/r/20250428-enable-rtc-v4-2-2b2f7e3f9349@baylibre.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Alexandre Mergnat and committed by
Alexandre Belloni
fe9f5f96 7df4cfef

+1 -1
+1 -1
drivers/rtc/class.c
··· 326 326 * 327 327 * Otherwise the offset seconds should be 0. 328 328 */ 329 - if (rtc->start_secs > rtc->range_max || 329 + if ((rtc->start_secs >= 0 && rtc->start_secs > rtc->range_max) || 330 330 rtc->start_secs + range_secs - 1 < rtc->range_min) 331 331 rtc->offset_secs = rtc->start_secs - rtc->range_min; 332 332 else if (rtc->start_secs > rtc->range_min)