Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[PATCH] copy_process: error path cleanup

This patch moves 'fork_out:' under 'bad_fork_free:', and removes now
unneeded 'if (retval)' check.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by

Oleg Nesterov and committed by
Linus Torvalds
fe7d37d1 ddc0f846

+2 -6
+2 -6
kernel/fork.c
··· 1146 1146 total_forks++; 1147 1147 write_unlock_irq(&tasklist_lock); 1148 1148 proc_fork_connector(p); 1149 - retval = 0; 1150 - 1151 - fork_out: 1152 - if (retval) 1153 - return ERR_PTR(retval); 1154 1149 return p; 1155 1150 1156 1151 bad_fork_cleanup_namespace: ··· 1186 1191 free_uid(p->user); 1187 1192 bad_fork_free: 1188 1193 free_task(p); 1189 - goto fork_out; 1194 + fork_out: 1195 + return ERR_PTR(retval); 1190 1196 } 1191 1197 1192 1198 struct pt_regs * __devinit __attribute__((weak)) idle_regs(struct pt_regs *regs)