Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dt-bindings: iommu: qcom_iommu: Allow 'tbu' clock

Some IOMMUs on some platforms (there doesn't seem to be a good denominator
for this) require the presence of a third clock, specifically relating
to the instance's Translation Buffer Unit (TBU).

Stephan Gerhold noted [1] that according to Qualcomm Snapdragon 410E
Processor (APQ8016E) Technical Reference Manual, SMMU chapter, section
"8.8.3.1.2 Clock gating", which reads:

For APPS TCU/TBU (TBU to TCU interface is asynchronous)
Software should turn ON clock to APPS TCU
- During APPS TCU register programming sequence

For GPU TCU/TBU (TBU to TCU interface is synchronous)
Software should turn ON clock to GPU TBU
- During GPU TLB invalidation sequence <=====================
Software should turn ON clock to GPU TCU
- During GPU TCU register programming sequence
- While GPU master clock is Active

The clock should be turned on at least during TLB invalidation on the
GPU SMMU instance. This is corroborated by Commit 5bc1cf1466f6
("iommu/qcom: add optional 'tbu' clock for TLB invalidate").

This is also not to be confused with qcom,sdm845-tbu, which is a
description of a debug interface, absent on the generation of hardware
that this binding describes.

Allow this clock.

[1] https://lore.kernel.org/linux-arm-msm/aPX_cKtial56AgvU@linaro.org/

Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Will Deacon <will@kernel.org>

authored by

Konrad Dybcio and committed by
Will Deacon
fe626291 45859c05

+4
+4
Documentation/devicetree/bindings/iommu/qcom,iommu.yaml
··· 32 32 - const: qcom,msm-iommu-v2 33 33 34 34 clocks: 35 + minItems: 2 35 36 items: 36 37 - description: Clock required for IOMMU register group access 37 38 - description: Clock required for underlying bus access 39 + - description: Clock required for Translation Buffer Unit access 38 40 39 41 clock-names: 42 + minItems: 2 40 43 items: 41 44 - const: iface 42 45 - const: bus 46 + - const: tbu 43 47 44 48 power-domains: 45 49 maxItems: 1