Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: intel/ipu6: Fix some redundant resources freeing in ipu6_pci_remove()

pcim_iomap_regions() and pcim_enable_device() are used in the probe. So
the corresponding managed resources don't need to be freed explicitly in
the remove function.

Remove the incorrect pci_release_regions() and pci_disable_device() calls.

Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

authored by

Christophe JAILLET and committed by
Hans Verkuil
fe61b290 fd7ccfb1

-3
-3
drivers/media/pci/intel/ipu6/ipu6.c
··· 727 727 pm_runtime_forbid(&pdev->dev); 728 728 pm_runtime_get_noresume(&pdev->dev); 729 729 730 - pci_release_regions(pdev); 731 - pci_disable_device(pdev); 732 - 733 730 release_firmware(isp->cpd_fw); 734 731 735 732 ipu6_mmu_cleanup(psys_mmu);