tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

selftests: net: local_termination: annotate the expected failures

Vladimir said when adding this test:

The bridge driver fares particularly badly [...] mainly because
it does not implement IFF_UNICAST_FLT.

See commit 90b9566aa5cd ("selftests: forwarding: add a test for
local_termination.sh").

We don't want to hide the known gaps, but having a test which
always fails prevents us from catching regressions. Report
the cases we know may fail as XFAIL.

Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Link: https://lore.kernel.org/r/20240516152513.1115270-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Jakub Kicinski fe56d6e4 f0fa8411

+18 -12
+18 -12
tools/testing/selftests/net/forwarding/local_termination.sh
··· 155 155 "$smac > $MACVLAN_ADDR, ethertype IPv4 (0x0800)" \ 156 156 true 157 157 158 - check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address" \ 159 - "$smac > $UNKNOWN_UC_ADDR1, ethertype IPv4 (0x0800)" \ 160 - false 158 + xfail_on_veth $h1 \ 159 + check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address" \ 160 + "$smac > $UNKNOWN_UC_ADDR1, ethertype IPv4 (0x0800)" \ 161 + false 161 162 162 163 check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address, promisc" \ 163 164 "$smac > $UNKNOWN_UC_ADDR2, ethertype IPv4 (0x0800)" \ 164 165 true 165 166 166 - check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address, allmulti" \ 167 - "$smac > $UNKNOWN_UC_ADDR3, ethertype IPv4 (0x0800)" \ 168 - false 167 + xfail_on_veth $h1 \ 168 + check_rcv $rcv_if_name \ 169 + "Unicast IPv4 to unknown MAC address, allmulti" \ 170 + "$smac > $UNKNOWN_UC_ADDR3, ethertype IPv4 (0x0800)" \ 171 + false 169 172 170 173 check_rcv $rcv_if_name "Multicast IPv4 to joined group" \ 171 174 "$smac > $JOINED_MACV4_MC_ADDR, ethertype IPv4 (0x0800)" \ 172 175 true 173 176 174 - check_rcv $rcv_if_name "Multicast IPv4 to unknown group" \ 175 - "$smac > $UNKNOWN_MACV4_MC_ADDR1, ethertype IPv4 (0x0800)" \ 176 - false 177 + xfail_on_veth $h1 \ 178 + check_rcv $rcv_if_name \ 179 + "Multicast IPv4 to unknown group" \ 180 + "$smac > $UNKNOWN_MACV4_MC_ADDR1, ethertype IPv4 (0x0800)" \ 181 + false 177 182 178 183 check_rcv $rcv_if_name "Multicast IPv4 to unknown group, promisc" \ 179 184 "$smac > $UNKNOWN_MACV4_MC_ADDR2, ethertype IPv4 (0x0800)" \ ··· 192 187 "$smac > $JOINED_MACV6_MC_ADDR, ethertype IPv6 (0x86dd)" \ 193 188 true 194 189 195 - check_rcv $rcv_if_name "Multicast IPv6 to unknown group" \ 196 - "$smac > $UNKNOWN_MACV6_MC_ADDR1, ethertype IPv6 (0x86dd)" \ 197 - false 190 + xfail_on_veth $h1 \ 191 + check_rcv $rcv_if_name "Multicast IPv6 to unknown group" \ 192 + "$smac > $UNKNOWN_MACV6_MC_ADDR1, ethertype IPv6 (0x86dd)" \ 193 + false 198 194 199 195 check_rcv $rcv_if_name "Multicast IPv6 to unknown group, promisc" \ 200 196 "$smac > $UNKNOWN_MACV6_MC_ADDR2, ethertype IPv6 (0x86dd)" \