Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

irqchip/ls-extirq: Fix devm_of_iomap() error check

The devm_of_iomap() function returns an ERR_PTR() encoded error code on
failure. Replace the incorrect check against NULL with IS_ERR().

Fixes: 05cd654829dd ("irqchip/ls-extirq: Convert to a platform driver to make it work again")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Herve Codina <herve.codina@bootlin.com>
Link: https://patch.msgid.link/20260224113610.1129022-3-ioana.ciornei@nxp.com
Closes: https://lore.kernel.org/all/aYXvfbfT6w0TMsXS@stanley.mountain/

authored by

Ioana Ciornei and committed by
Thomas Gleixner
fe5669e3 e08f2adc

+4 -2
+4 -2
drivers/irqchip/irq-ls-extirq.c
··· 190 190 return dev_err_probe(dev, -ENOMEM, "Failed to allocate memory\n"); 191 191 192 192 priv->intpcr = devm_of_iomap(dev, node, 0, NULL); 193 - if (!priv->intpcr) 194 - return dev_err_probe(dev, -ENOMEM, "Cannot ioremap OF node %pOF\n", node); 193 + if (IS_ERR(priv->intpcr)) { 194 + return dev_err_probe(dev, PTR_ERR(priv->intpcr), 195 + "Cannot ioremap OF node %pOF\n", node); 196 + } 195 197 196 198 ret = ls_extirq_parse_map(priv, node); 197 199 if (ret)