Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers/net: Convert remaining uses of pr_warning to pr_warn

Use the much more common pr_warn instead of pr_warning.

Other miscellanea:

o Typo fixes submiting/submitting
o Coalesce formats
o Realign arguments
o Add missing terminating '\n' to formats

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Joe Perches and committed by
David S. Miller
fe3881cf 46cfd725

+62 -68
+3 -3
drivers/net/ethernet/3com/3c509.c
··· 695 695 int ioaddr = dev->base_addr; 696 696 697 697 /* Transmitter timeout, serious problems. */ 698 - pr_warning("%s: transmit timed out, Tx_status %2.2x status %4.4x Tx FIFO room %d.\n", 699 - dev->name, inb(ioaddr + TX_STATUS), inw(ioaddr + EL3_STATUS), 700 - inw(ioaddr + TX_FREE)); 698 + pr_warn("%s: transmit timed out, Tx_status %2.2x status %4.4x Tx FIFO room %d\n", 699 + dev->name, inb(ioaddr + TX_STATUS), inw(ioaddr + EL3_STATUS), 700 + inw(ioaddr + TX_FREE)); 701 701 dev->stats.tx_errors++; 702 702 dev->trans_start = jiffies; /* prevent tx timeout */ 703 703 /* Issue TX_RESET and TX_START commands. */
+11 -14
drivers/net/ethernet/3com/3c515.c
··· 515 515 if (pnp_device_attach(idev) < 0) 516 516 continue; 517 517 if (pnp_activate_dev(idev) < 0) { 518 - pr_warning("pnp activate failed (out of resources?)\n"); 518 + pr_warn("pnp activate failed (out of resources?)\n"); 519 519 pnp_device_detach(idev); 520 520 continue; 521 521 } ··· 659 659 pr_cont(", IRQ %d\n", dev->irq); 660 660 /* Tell them about an invalid IRQ. */ 661 661 if (corkscrew_debug && (dev->irq <= 0 || dev->irq > 15)) 662 - pr_warning(" *** Warning: this IRQ is unlikely to work! ***\n"); 662 + pr_warn(" *** Warning: this IRQ is unlikely to work! ***\n"); 663 663 664 664 { 665 665 static const char * const ram_split[] = { ··· 967 967 struct corkscrew_private *vp = netdev_priv(dev); 968 968 int ioaddr = dev->base_addr; 969 969 970 - pr_warning("%s: transmit timed out, tx_status %2.2x status %4.4x.\n", 971 - dev->name, inb(ioaddr + TxStatus), 972 - inw(ioaddr + EL3_STATUS)); 970 + pr_warn("%s: transmit timed out, tx_status %2.2x status %4.4x\n", 971 + dev->name, inb(ioaddr + TxStatus), 972 + inw(ioaddr + EL3_STATUS)); 973 973 /* Slight code bloat to be user friendly. */ 974 974 if ((inb(ioaddr + TxStatus) & 0x88) == 0x88) 975 - pr_warning("%s: Transmitter encountered 16 collisions --" 976 - " network cable problem?\n", dev->name); 975 + pr_warn("%s: Transmitter encountered 16 collisions -- network cable problem?\n", 976 + dev->name); 977 977 #ifndef final_version 978 978 pr_debug(" Flags; bus-master %d, full %d; dirty %d current %d.\n", 979 979 vp->full_bus_master_tx, vp->tx_full, vp->dirty_tx, ··· 1382 1382 temp = skb_put(skb, pkt_len); 1383 1383 /* Remove this checking code for final release. */ 1384 1384 if (isa_bus_to_virt(vp->rx_ring[entry].addr) != temp) 1385 - pr_warning("%s: Warning -- the skbuff addresses do not match" 1386 - " in boomerang_rx: %p vs. %p / %p.\n", 1387 - dev->name, 1388 - isa_bus_to_virt(vp-> 1389 - rx_ring[entry]. 1390 - addr), skb->head, 1391 - temp); 1385 + pr_warn("%s: Warning -- the skbuff addresses do not match in boomerang_rx: %p vs. %p / %p\n", 1386 + dev->name, 1387 + isa_bus_to_virt(vp->rx_ring[entry].addr), 1388 + skb->head, temp); 1392 1389 rx_nocopy++; 1393 1390 } 1394 1391 skb->protocol = eth_type_trans(skb, dev);
+14 -13
drivers/net/ethernet/3com/3c59x.c
··· 1310 1310 pr_cont(", IRQ %d\n", dev->irq); 1311 1311 /* Tell them about an invalid IRQ. */ 1312 1312 if (dev->irq <= 0 || dev->irq >= nr_irqs) 1313 - pr_warning(" *** Warning: IRQ %d is unlikely to work! ***\n", 1314 - dev->irq); 1313 + pr_warn(" *** Warning: IRQ %d is unlikely to work! ***\n", 1314 + dev->irq); 1315 1315 1316 1316 step = (window_read8(vp, 4, Wn4_NetDiag) & 0x1e) >> 1; 1317 1317 if (print_info) { ··· 1425 1425 } 1426 1426 mii_preamble_required--; 1427 1427 if (phy_idx == 0) { 1428 - pr_warning(" ***WARNING*** No MII transceivers found!\n"); 1428 + pr_warn(" ***WARNING*** No MII transceivers found!\n"); 1429 1429 vp->phys[0] = 24; 1430 1430 } else { 1431 1431 vp->advertising = mdio_read(dev, vp->phys[0], MII_ADVERTISE); ··· 1566 1566 pci_restore_state(VORTEX_PCI(vp)); 1567 1567 err = pci_enable_device(VORTEX_PCI(vp)); 1568 1568 if (err) { 1569 - pr_warning("%s: Could not enable device\n", 1570 - dev->name); 1569 + pr_warn("%s: Could not enable device\n", dev->name); 1571 1570 goto err_out; 1572 1571 } 1573 1572 } ··· 2006 2007 /* This occurs when we have the wrong media type! */ 2007 2008 if (DoneDidThat == 0 && 2008 2009 ioread16(ioaddr + EL3_STATUS) & StatsFull) { 2009 - pr_warning("%s: Updating statistics failed, disabling " 2010 - "stats as an interrupt source.\n", dev->name); 2010 + pr_warn("%s: Updating statistics failed, disabling stats as an interrupt source\n", 2011 + dev->name); 2011 2012 iowrite16(SetIntrEnb | 2012 2013 (window_read16(vp, 5, 10) & ~StatsFull), 2013 2014 ioaddr + EL3_CMD); ··· 2146 2147 2147 2148 if (vp->cur_tx - vp->dirty_tx >= TX_RING_SIZE) { 2148 2149 if (vortex_debug > 0) 2149 - pr_warning("%s: BUG! Tx Ring full, refusing to send buffer.\n", 2150 - dev->name); 2150 + pr_warn("%s: BUG! Tx Ring full, refusing to send buffer\n", 2151 + dev->name); 2151 2152 netif_stop_queue(dev); 2152 2153 return NETDEV_TX_BUSY; 2153 2154 } ··· 2310 2311 } 2311 2312 2312 2313 if (--work_done < 0) { 2313 - pr_warning("%s: Too much work in interrupt, status %4.4x.\n", 2314 + pr_warn("%s: Too much work in interrupt, status %4.4x\n", 2314 2315 dev->name, status); 2315 2316 /* Disable all pending interrupts. */ 2316 2317 do { ··· 2443 2444 vortex_error(dev, status); 2444 2445 2445 2446 if (--work_done < 0) { 2446 - pr_warning("%s: Too much work in interrupt, status %4.4x.\n", 2447 + pr_warn("%s: Too much work in interrupt, status %4.4x\n", 2447 2448 dev->name, status); 2448 2449 /* Disable all pending interrupts. */ 2449 2450 do { ··· 2619 2620 if (skb == NULL) { 2620 2621 static unsigned long last_jif; 2621 2622 if (time_after(jiffies, last_jif + 10 * HZ)) { 2622 - pr_warning("%s: memory shortage\n", dev->name); 2623 + pr_warn("%s: memory shortage\n", 2624 + dev->name); 2623 2625 last_jif = jiffies; 2624 2626 } 2625 2627 if ((vp->cur_rx - vp->dirty_rx) == RX_RING_SIZE) ··· 2719 2719 if (vp->rx_csumhits && 2720 2720 (vp->drv_flags & HAS_HWCKSM) == 0 && 2721 2721 (vp->card_idx >= MAX_UNITS || hw_checksums[vp->card_idx] == -1)) { 2722 - pr_warning("%s supports hardware checksums, and we're not using them!\n", dev->name); 2722 + pr_warn("%s supports hardware checksums, and we're not using them!\n", 2723 + dev->name); 2723 2724 } 2724 2725 #endif 2725 2726
+1 -1
drivers/net/ethernet/broadcom/b44.c
··· 427 427 } 428 428 return; 429 429 error: 430 - pr_warning("PHY: cannot reset MII transceiver isolate bit\n"); 430 + pr_warn("PHY: cannot reset MII transceiver isolate bit\n"); 431 431 } 432 432 #else 433 433 static inline void b44_wap54g10_workaround(struct b44 *bp)
+1 -2
drivers/net/ethernet/cisco/enic/vnic_dev.c
··· 847 847 */ 848 848 if ((err == ERR_ECMDUNKNOWN) || 849 849 (!err && !(vdev->args[0] && vdev->args[1] && vdev->args[2]))) { 850 - pr_warning("Using default conversion factor for " 851 - "interrupt coalesce timer\n"); 850 + pr_warn("Using default conversion factor for interrupt coalesce timer\n"); 852 851 vnic_dev_intr_coal_timer_info_default(vdev); 853 852 return 0; 854 853 }
+3 -3
drivers/net/ethernet/marvell/skge.c
··· 1107 1107 { 1108 1108 u16 v = 0; 1109 1109 if (__xm_phy_read(hw, port, reg, &v)) 1110 - pr_warning("%s: phy read timed out\n", hw->dev[port]->name); 1110 + pr_warn("%s: phy read timed out\n", hw->dev[port]->name); 1111 1111 return v; 1112 1112 } 1113 1113 ··· 1903 1903 return 0; 1904 1904 } 1905 1905 1906 - pr_warning("%s: phy write timeout\n", hw->dev[port]->name); 1906 + pr_warn("%s: phy write timeout\n", hw->dev[port]->name); 1907 1907 return -EIO; 1908 1908 } 1909 1909 ··· 1931 1931 { 1932 1932 u16 v = 0; 1933 1933 if (__gm_phy_read(hw, port, reg, &v)) 1934 - pr_warning("%s: phy read timeout\n", hw->dev[port]->name); 1934 + pr_warn("%s: phy read timeout\n", hw->dev[port]->name); 1935 1935 return v; 1936 1936 } 1937 1937
+1 -1
drivers/net/ethernet/marvell/sky2.c
··· 2814 2814 2815 2815 default: 2816 2816 if (net_ratelimit()) 2817 - pr_warning("unknown status opcode 0x%x\n", opcode); 2817 + pr_warn("unknown status opcode 0x%x\n", opcode); 2818 2818 } 2819 2819 } while (hw->st_idx != idx); 2820 2820
+2 -2
drivers/net/ethernet/packetengines/yellowfin.c
··· 693 693 /* Note: these should be KERN_DEBUG. */ 694 694 if (yellowfin_debug) { 695 695 int i; 696 - pr_warning(" Rx ring %p: ", yp->rx_ring); 696 + pr_warn(" Rx ring %p: ", yp->rx_ring); 697 697 for (i = 0; i < RX_RING_SIZE; i++) 698 698 pr_cont(" %08x", yp->rx_ring[i].result_status); 699 699 pr_cont("\n"); 700 - pr_warning(" Tx ring %p: ", yp->tx_ring); 700 + pr_warn(" Tx ring %p: ", yp->tx_ring); 701 701 for (i = 0; i < TX_RING_SIZE; i++) 702 702 pr_cont(" %04x /%08x", 703 703 yp->tx_status[i].tx_errs,
+2 -3
drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
··· 1477 1477 u32 val; 1478 1478 1479 1479 if (pdev->revision >= NX_P3_A0 && pdev->revision <= NX_P3_B1) { 1480 - pr_warning("%s: chip revisions between 0x%x-0x%x " 1481 - "will not be enabled.\n", 1482 - module_name(THIS_MODULE), NX_P3_A0, NX_P3_B1); 1480 + pr_warn("%s: chip revisions between 0x%x-0x%x will not be enabled\n", 1481 + module_name(THIS_MODULE), NX_P3_A0, NX_P3_B1); 1483 1482 return -ENODEV; 1484 1483 } 1485 1484
+1 -1
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
··· 282 282 } 283 283 284 284 if (!found) { 285 - pr_warning("%s: No PHY found\n", ndev->name); 285 + pr_warn("%s: No PHY found\n", ndev->name); 286 286 mdiobus_unregister(new_bus); 287 287 mdiobus_free(new_bus); 288 288 return -ENODEV;
+1 -1
drivers/net/ethernet/sun/cassini.c
··· 4962 4962 pci_cmd |= PCI_COMMAND_PARITY; 4963 4963 pci_write_config_word(pdev, PCI_COMMAND, pci_cmd); 4964 4964 if (pci_try_set_mwi(pdev)) 4965 - pr_warning("Could not enable MWI for %s\n", pci_name(pdev)); 4965 + pr_warn("Could not enable MWI for %s\n", pci_name(pdev)); 4966 4966 4967 4967 cas_program_bridge(pdev); 4968 4968
+2 -2
drivers/net/ethernet/sun/niu.c
··· 8717 8717 parent->txchan_per_port[i] = 1; 8718 8718 } 8719 8719 if (tot_rx < NIU_NUM_RXCHAN || tot_tx < NIU_NUM_TXCHAN) { 8720 - pr_warning("niu%d: Driver bug, wasted channels, RX[%d] TX[%d]\n", 8721 - parent->index, tot_rx, tot_tx); 8720 + pr_warn("niu%d: Driver bug, wasted channels, RX[%d] TX[%d]\n", 8721 + parent->index, tot_rx, tot_tx); 8722 8722 } 8723 8723 } 8724 8724
+1 -1
drivers/net/ethernet/sun/sunvnet.c
··· 534 534 } 535 535 536 536 if (unlikely(event != LDC_EVENT_DATA_READY)) { 537 - pr_warning("Unexpected LDC event %d\n", event); 537 + pr_warn("Unexpected LDC event %d\n", event); 538 538 spin_unlock_irqrestore(&vio->lock, flags); 539 539 return; 540 540 }
+3 -5
drivers/net/ethernet/tile/tilepro.c
··· 956 956 */ 957 957 if (hv_dev_pwrite(priv->hv_devhdl, 0, (HV_VirtAddr)&dummy, 958 958 sizeof(dummy), NETIO_IPP_START_SHIM_OFF) < 0) { 959 - pr_warning("Failed to start LIPP/LEPP.\n"); 959 + pr_warn("Failed to start LIPP/LEPP\n"); 960 960 return -EIO; 961 961 } 962 962 ··· 2399 2399 { 2400 2400 int rc = cpulist_parse_crop(str, &network_cpus_map); 2401 2401 if (rc != 0) { 2402 - pr_warning("network_cpus=%s: malformed cpu list\n", 2403 - str); 2402 + pr_warn("network_cpus=%s: malformed cpu list\n", str); 2404 2403 } else { 2405 2404 2406 2405 /* Remove dedicated cpus. */ ··· 2408 2409 2409 2410 2410 2411 if (cpumask_empty(&network_cpus_map)) { 2411 - pr_warning("Ignoring network_cpus='%s'.\n", 2412 - str); 2412 + pr_warn("Ignoring network_cpus='%s'\n", str); 2413 2413 } else { 2414 2414 char buf[1024]; 2415 2415 cpulist_scnprintf(buf, sizeof(buf), &network_cpus_map);
+1 -1
drivers/net/wireless/mwifiex/usb.c
··· 357 357 card->usb_boot_state = USB8XXX_FW_READY; 358 358 break; 359 359 default: 360 - pr_warning("unknown id_product %#x\n", id_product); 360 + pr_warn("unknown id_product %#x\n", id_product); 361 361 card->usb_boot_state = USB8XXX_FW_DNLD; 362 362 break; 363 363 }
+14 -14
drivers/net/wireless/orinoco/orinoco_usb.c
··· 534 534 535 535 if (ctx->killed) { 536 536 spin_unlock_irqrestore(&upriv->req_lock, flags); 537 - pr_warning("interrupt called with dead ctx"); 537 + pr_warn("interrupt called with dead ctx\n"); 538 538 goto out; 539 539 } 540 540 ··· 671 671 default: 672 672 spin_unlock_irqrestore(&upriv->req_lock, flags); 673 673 674 - pr_warning("Matched IN URB, unexpected context state(0x%x)", 675 - state); 674 + pr_warn("Matched IN URB, unexpected context state(0x%x)\n", 675 + state); 676 676 /* Throw this CTX away and try submitting another */ 677 677 del_timer(&ctx->timer); 678 678 ctx->outurb->transfer_flags |= URB_ASYNC_UNLINK; ··· 1394 1394 /* When a device gets unplugged we get this every time 1395 1395 * we resubmit, flooding the logs. Since we don't use 1396 1396 * USB timeouts, it shouldn't happen any other time*/ 1397 - pr_warning("%s: urb timed out, not resubmiting", __func__); 1397 + pr_warn("%s: urb timed out, not resubmitting\n", __func__); 1398 1398 return; 1399 1399 } 1400 1400 if (urb->status == -ECONNABORTED) { 1401 - pr_warning("%s: connection abort, resubmiting urb", 1402 - __func__); 1401 + pr_warn("%s: connection abort, resubmitting urb\n", 1402 + __func__); 1403 1403 goto resubmit; 1404 1404 } 1405 1405 if ((urb->status == -EILSEQ) ··· 1608 1608 if (usb_endpoint_is_bulk_in(ep)) { 1609 1609 /* we found a bulk in endpoint */ 1610 1610 if (upriv->read_urb != NULL) { 1611 - pr_warning("Found a second bulk in ep, ignored"); 1611 + pr_warn("Found a second bulk in ep, ignored\n"); 1612 1612 continue; 1613 1613 } 1614 1614 ··· 1618 1618 goto error; 1619 1619 } 1620 1620 if (le16_to_cpu(ep->wMaxPacketSize) != 64) 1621 - pr_warning("bulk in: wMaxPacketSize!= 64"); 1621 + pr_warn("bulk in: wMaxPacketSize!= 64\n"); 1622 1622 if (ep->bEndpointAddress != (2 | USB_DIR_IN)) 1623 - pr_warning("bulk in: bEndpointAddress: %d", 1624 - ep->bEndpointAddress); 1623 + pr_warn("bulk in: bEndpointAddress: %d\n", 1624 + ep->bEndpointAddress); 1625 1625 upriv->read_pipe = usb_rcvbulkpipe(udev, 1626 1626 ep-> 1627 1627 bEndpointAddress); ··· 1636 1636 if (usb_endpoint_is_bulk_out(ep)) { 1637 1637 /* we found a bulk out endpoint */ 1638 1638 if (upriv->bap_buf != NULL) { 1639 - pr_warning("Found a second bulk out ep, ignored"); 1639 + pr_warn("Found a second bulk out ep, ignored\n"); 1640 1640 continue; 1641 1641 } 1642 1642 1643 1643 if (le16_to_cpu(ep->wMaxPacketSize) != 64) 1644 - pr_warning("bulk out: wMaxPacketSize != 64"); 1644 + pr_warn("bulk out: wMaxPacketSize != 64\n"); 1645 1645 if (ep->bEndpointAddress != 2) 1646 - pr_warning("bulk out: bEndpointAddress: %d", 1647 - ep->bEndpointAddress); 1646 + pr_warn("bulk out: bEndpointAddress: %d\n", 1647 + ep->bEndpointAddress); 1648 1648 upriv->write_pipe = usb_sndbulkpipe(udev, 1649 1649 ep-> 1650 1650 bEndpointAddress);
+1 -1
drivers/net/wireless/ti/wlcore/debug.h
··· 65 65 pr_err(DRIVER_PREFIX "ERROR " fmt "\n", ##arg) 66 66 67 67 #define wl1271_warning(fmt, arg...) \ 68 - pr_warning(DRIVER_PREFIX "WARNING " fmt "\n", ##arg) 68 + pr_warn(DRIVER_PREFIX "WARNING " fmt "\n", ##arg) 69 69 70 70 #define wl1271_notice(fmt, arg...) \ 71 71 pr_info(DRIVER_PREFIX fmt "\n", ##arg)