Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ASoC: codecs: es8326: Fix DTS properties reading

Seems like properties parsing and reading was copy-pasted,
so "everest,interrupt-src" and "everest,interrupt-clk" are saved into
the es8326->jack_pol variable. This might lead to wrong settings
being saved into the reg 57 (ES8326_HP_DET).

Fix this by using proper variables while reading properties.

Signed-off-by: Alexey Firago <a.firago@yadro.com>
Reviewed-by: Yang Yingliang <yangyingliang@huawei.com
Link: https://lore.kernel.org/r/20230204195106.46539-1-a.firago@yadro.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Alexey Firago and committed by
Mark Brown
fe1e7e8c 2e7c6652

+4 -2
+4 -2
sound/soc/codecs/es8326.c
··· 729 729 } 730 730 dev_dbg(component->dev, "jack-pol %x", es8326->jack_pol); 731 731 732 - ret = device_property_read_u8(component->dev, "everest,interrupt-src", &es8326->jack_pol); 732 + ret = device_property_read_u8(component->dev, "everest,interrupt-src", 733 + &es8326->interrupt_src); 733 734 if (ret != 0) { 734 735 dev_dbg(component->dev, "interrupt-src return %d", ret); 735 736 es8326->interrupt_src = ES8326_HP_DET_SRC_PIN9; 736 737 } 737 738 dev_dbg(component->dev, "interrupt-src %x", es8326->interrupt_src); 738 739 739 - ret = device_property_read_u8(component->dev, "everest,interrupt-clk", &es8326->jack_pol); 740 + ret = device_property_read_u8(component->dev, "everest,interrupt-clk", 741 + &es8326->interrupt_clk); 740 742 if (ret != 0) { 741 743 dev_dbg(component->dev, "interrupt-clk return %d", ret); 742 744 es8326->interrupt_clk = 0x45;