Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dmaengine: milbeaut-hdmac: Prefer kcalloc over open coded arithmetic

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument
size * count in the kzalloc() function.

[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Signed-off-by: Len Baker <len.baker@gmx.com>
Link: https://lore.kernel.org/r/20210904145813.5161-1-len.baker@gmx.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Len Baker and committed by
Vinod Koul
fe14c672 dbe3c54e

+1 -1
+1 -1
drivers/dma/milbeaut-hdmac.c
··· 269 269 if (!md) 270 270 return NULL; 271 271 272 - md->sgl = kzalloc(sizeof(*sgl) * sg_len, GFP_NOWAIT); 272 + md->sgl = kcalloc(sg_len, sizeof(*sgl), GFP_NOWAIT); 273 273 if (!md->sgl) { 274 274 kfree(md); 275 275 return NULL;