Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PCI: xgene: Drop XGENE_PCIE_IP_VER_UNKN

XGENE_PCIE_IP_VER_UNKN is only refered to when probing for the
original XGene PCIe implementation, and get immediately overridden
if the device has the "apm,xgene-pcie" compatible string.

Given that the only way to get there is by finding this very string in
the DT, it is obvious that we will always overwrite the version with
XGENE_PCIE_IP_VER_1.

Drop the whole thing.

Signed-off-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://lore.kernel.org/r/20250708173404.1278635-5-maz@kernel.org

authored by

Marc Zyngier and committed by
Bjorn Helgaas
fddf72ed e3ac25cc

+1 -5
+1 -5
drivers/pci/controller/pci-xgene.c
··· 54 54 #define XGENE_V1_PCI_EXP_CAP 0x40 55 55 56 56 /* PCIe IP version */ 57 - #define XGENE_PCIE_IP_VER_UNKN 0 58 57 #define XGENE_PCIE_IP_VER_1 1 59 58 #define XGENE_PCIE_IP_VER_2 2 60 59 ··· 629 630 630 631 port->node = of_node_get(dn); 631 632 port->dev = dev; 632 - 633 - port->version = XGENE_PCIE_IP_VER_UNKN; 634 - if (of_device_is_compatible(port->node, "apm,xgene-pcie")) 635 - port->version = XGENE_PCIE_IP_VER_1; 633 + port->version = XGENE_PCIE_IP_VER_1; 636 634 637 635 ret = xgene_pcie_map_reg(port, pdev); 638 636 if (ret)