Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ipack: fix ipack.h kernel-doc warnings

Fix various kernel-doc warnings in ipack.h:

- Remove an empty kernel-doc comment.
- Add 2 missing struct short descriptions.
- Fix a typo in a description.
- Add a missing struct field description.
- Add some missing Return descriptions.
- Clarify one function short description.

Warning: ../include/linux/ipack.h:73 Cannot find identifier on line:
*/
Warning: ../include/linux/ipack.h:74 Cannot find identifier on line:
struct ipack_region {
Warning: ../include/linux/ipack.h:75 Cannot find identifier on line:
phys_addr_t start;
Warning: ../include/linux/ipack.h:76 Cannot find identifier on line:
size_t size;
Warning: ../include/linux/ipack.h:77 Cannot find identifier on line:
};
Warning: ../include/linux/ipack.h:78 Cannot find identifier on line:

Warning: ../include/linux/ipack.h:79 Cannot find identifier on line:
/**
Warning: ipack.h:80 missing initial short description on line:
* struct ipack_device
Warning: ipack.h:163 missing initial short description on line:
* struct ipack_bus_device
Warning: ipack.h:130 struct member 'id_table' not described in 'ipack_driver'
Warning: ipack.h:189 No description found for return value of 'ipack_bus_register'
Warning: ipack.h:194 No description found for return value of 'ipack_bus_unregister' ***
Warning: ipack.h:202 No description found for return value of 'ipack_driver_register'
Warning: ipack.h:221 No description found for return value of 'ipack_device_init'
Warning: ipack.h:236 No description found for return value of 'ipack_device_add'
Warning: ipack.h:271 No description found for return value of 'ipack_get_carrier'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Link: https://patch.msgid.link/20251016033543.1142049-1-rdunlap@infradead.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Randy Dunlap and committed by
Greg Kroah-Hartman
fdd00d79 3a866087

+15 -8
+15 -8
include/linux/ipack.h
··· 70 70 IPACK_SPACE_COUNT, 71 71 }; 72 72 73 - /** 74 - */ 75 73 struct ipack_region { 76 74 phys_addr_t start; 77 75 size_t size; 78 76 }; 79 77 80 78 /** 81 - * struct ipack_device 79 + * struct ipack_device - subsystem representation of an IPack device 82 80 * 83 81 * @slot: Slot where the device is plugged in the carrier board 84 82 * @bus: ipack_bus_device where the device is plugged to. ··· 87 89 * 88 90 * Warning: Direct access to mapped memory is possible but the endianness 89 91 * is not the same with PCI carrier or VME carrier. The endianness is managed 90 - * by the carrier board throught bus->ops. 92 + * by the carrier board through bus->ops. 91 93 */ 92 94 struct ipack_device { 93 95 unsigned int slot; ··· 122 124 * struct ipack_driver -- Specific data to each ipack device driver 123 125 * 124 126 * @driver: Device driver kernel representation 127 + * @id_table: Device ID table for this driver 125 128 * @ops: Callbacks provided by the IPack device driver 126 129 */ 127 130 struct ipack_driver { ··· 160 161 }; 161 162 162 163 /** 163 - * struct ipack_bus_device 164 + * struct ipack_bus_device - IPack bus representation 164 165 * 165 166 * @dev: pointer to carrier device 166 167 * @slots: number of slots available ··· 184 185 * 185 186 * The carrier board device should call this function to register itself as 186 187 * available bus device in ipack. 188 + * 189 + * Return: %NULL on error or &struct ipack_bus_device on success 187 190 */ 188 191 struct ipack_bus_device *ipack_bus_register(struct device *parent, int slots, 189 192 const struct ipack_bus_ops *ops, ··· 193 192 194 193 /** 195 194 * ipack_bus_unregister -- unregister an ipack bus 195 + * 196 + * Return: %0 196 197 */ 197 198 int ipack_bus_unregister(struct ipack_bus_device *bus); 198 199 ··· 203 200 * 204 201 * Called by a ipack driver to register itself as a driver 205 202 * that can manage ipack devices. 203 + * 204 + * Return: zero on success or error code on failure. 206 205 */ 207 206 int ipack_driver_register(struct ipack_driver *edrv, struct module *owner, 208 207 const char *name); ··· 220 215 * function. The rest of the fields will be allocated and populated 221 216 * during initalization. 222 217 * 223 - * Return zero on success or error code on failure. 218 + * Return: zero on success or error code on failure. 224 219 * 225 220 * NOTE: _Never_ directly free @dev after calling this function, even 226 221 * if it returned an error! Always use ipack_put_device() to give up the ··· 235 230 * Add a new IPack device. The call is done by the carrier driver 236 231 * after calling ipack_device_init(). 237 232 * 238 - * Return zero on success or error code on failure. 233 + * Return: zero on success or error code on failure. 239 234 * 240 235 * NOTE: _Never_ directly free @dev after calling this function, even 241 236 * if it returned an error! Always use ipack_put_device() to give up the ··· 271 266 .device = (dev) 272 267 273 268 /** 274 - * ipack_get_carrier - it increase the carrier ref. counter of 269 + * ipack_get_carrier - try to increase the carrier ref. counter of 275 270 * the carrier module 276 271 * @dev: mezzanine device which wants to get the carrier 272 + * 273 + * Return: true on success. 277 274 */ 278 275 static inline int ipack_get_carrier(struct ipack_device *dev) 279 276 {