Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clocksource/drivers/exynos_mct: Explicitly return 0 for shared timer

For a shared timers, the mct_init_dt() should not initialize the clock
even with global comparator. This is not an error, thus the function
should simply return 0, not 'ret'.

This also fixes smatch warning:

drivers/clocksource/exynos_mct.c:635 mct_init_dt() warn: missing error code? 'ret'

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/202304021446.46XVKag0-lkp@intel.com/
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230403094017.9556-1-krzysztof.kozlowski@linaro.org

authored by

Krzysztof Kozlowski and committed by
Daniel Lezcano
fd3f088f f7abf14f

+1 -1
+1 -1
drivers/clocksource/exynos_mct.c
··· 682 682 * processor cannot use the global comparator. 683 683 */ 684 684 if (frc_shared) 685 - return ret; 685 + return 0; 686 686 687 687 return exynos4_clockevent_init(); 688 688 }