Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

misc: tifm: fix possible memory leak in tifm_7xx1_switch_media()

If device_register() returns error in tifm_7xx1_switch_media(),
name of kobject which is allocated in dev_set_name() called in device_add()
is leaked.

Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized.

Fixes: 2428a8fe2261 ("tifm: move common device management tasks from tifm_7xx1 to tifm_core")
Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20221117064725.3478402-1-ruanjinjie@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

ruanjinjie and committed by
Greg Kroah-Hartman
fd2c930c 1dbb4f02

+1 -1
+1 -1
drivers/misc/tifm_7xx1.c
··· 190 190 spin_unlock_irqrestore(&fm->lock, flags); 191 191 } 192 192 if (sock) 193 - tifm_free_device(&sock->dev); 193 + put_device(&sock->dev); 194 194 } 195 195 spin_lock_irqsave(&fm->lock, flags); 196 196 }