Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Staging: comedi: remove some RT code that lingered

This removes some pieces of RT code that was part of the main code
paths.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

+24 -42
-1
drivers/staging/comedi/comedi.h
··· 188 188 #define SDF_WRITABLE 0x00020000 /* subdevice can be written (e.g. analog output) */ 189 189 #define SDF_WRITEABLE SDF_WRITABLE /* spelling error in API */ 190 190 #define SDF_INTERNAL 0x00040000 /* subdevice does not have externally visible lines */ 191 - #define SDF_RT 0x00080000 /* DEPRECATED: subdevice is RT capable */ 192 191 #define SDF_GROUND 0x00100000 /* can do aref=ground */ 193 192 #define SDF_COMMON 0x00200000 /* can do aref=common */ 194 193 #define SDF_DIFF 0x00400000 /* can do aref=diff */
+8 -17
drivers/staging/comedi/comedi_fops.c
··· 1998 1998 1999 1999 if (async->cb_mask & s->async->events) { 2000 2000 if (comedi_get_subdevice_runflags(s) & SRF_USER) { 2001 - if (dev->rt) { 2002 - printk("BUG: comedi_event() code unreachable\n"); 2003 - } else { 2004 - wake_up_interruptible(&async->wait_head); 2005 - if (s->subdev_flags & SDF_CMD_READ) { 2006 - kill_fasync(&dev->async_queue, SIGIO, 2007 - POLL_IN); 2008 - } 2009 - if (s->subdev_flags & SDF_CMD_WRITE) { 2010 - kill_fasync(&dev->async_queue, SIGIO, 2011 - POLL_OUT); 2012 - } 2001 + wake_up_interruptible(&async->wait_head); 2002 + if (s->subdev_flags & SDF_CMD_READ) { 2003 + kill_fasync(&dev->async_queue, SIGIO, 2004 + POLL_IN); 2005 + } 2006 + if (s->subdev_flags & SDF_CMD_WRITE) { 2007 + kill_fasync(&dev->async_queue, SIGIO, 2008 + POLL_OUT); 2013 2009 } 2014 2010 } else { 2015 2011 if (async->cb_func) 2016 2012 async->cb_func(s->async->events, async->cb_arg); 2017 - /* XXX bug here. If subdevice A is rt, and 2018 - * subdevice B tries to callback to a normal 2019 - * linux kernel function, it will be at the 2020 - * wrong priority. Since this isn't very 2021 - * common, I'm not going to worry about it. */ 2022 2013 } 2023 2014 } 2024 2015 s->async->events = 0;
-1
drivers/staging/comedi/comedidev.h
··· 263 263 const char *board_name; 264 264 const void *board_ptr; 265 265 int attached; 266 - int rt; 267 266 spinlock_t spinlock; 268 267 struct mutex mutex; 269 268 int in_request_module;
+6 -13
drivers/staging/comedi/drivers/addi-data/addi_common.c
··· 2757 2757 dev->read_subdev = s; 2758 2758 s->type = COMEDI_SUBD_AI; 2759 2759 s->subdev_flags = 2760 - SDF_READABLE | SDF_RT | SDF_COMMON | SDF_GROUND 2760 + SDF_READABLE | SDF_COMMON | SDF_GROUND 2761 2761 | SDF_DIFF; 2762 2762 if (this_board->i_NbrAiChannel) { 2763 2763 s->n_chan = this_board->i_NbrAiChannel; ··· 2792 2792 s = dev->subdevices + 1; 2793 2793 if (this_board->i_NbrAoChannel) { 2794 2794 s->type = COMEDI_SUBD_AO; 2795 - s->subdev_flags = 2796 - SDF_WRITEABLE | SDF_GROUND | SDF_COMMON | 2797 - SDF_RT; 2795 + s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON; 2798 2796 s->n_chan = this_board->i_NbrAoChannel; 2799 2797 s->maxdata = this_board->i_AoMaxdata; 2800 2798 s->len_chanlist = this_board->i_NbrAoChannel; ··· 2808 2810 s = dev->subdevices + 2; 2809 2811 if (this_board->i_NbrDiChannel) { 2810 2812 s->type = COMEDI_SUBD_DI; 2811 - s->subdev_flags = 2812 - SDF_READABLE | SDF_RT | SDF_GROUND | SDF_COMMON; 2813 + s->subdev_flags = SDF_READABLE | SDF_GROUND | SDF_COMMON; 2813 2814 s->n_chan = this_board->i_NbrDiChannel; 2814 2815 s->maxdata = 1; 2815 2816 s->len_chanlist = this_board->i_NbrDiChannel; ··· 2828 2831 if (this_board->i_NbrDoChannel) { 2829 2832 s->type = COMEDI_SUBD_DO; 2830 2833 s->subdev_flags = 2831 - SDF_READABLE | SDF_WRITEABLE | SDF_RT | 2832 - SDF_GROUND | SDF_COMMON; 2834 + SDF_READABLE | SDF_WRITEABLE | SDF_GROUND | SDF_COMMON; 2833 2835 s->n_chan = this_board->i_NbrDoChannel; 2834 2836 s->maxdata = this_board->i_DoMaxdata; 2835 2837 s->len_chanlist = this_board->i_NbrDoChannel; ··· 2850 2854 s = dev->subdevices + 4; 2851 2855 if (this_board->i_Timer) { 2852 2856 s->type = COMEDI_SUBD_TIMER; 2853 - s->subdev_flags = 2854 - SDF_WRITEABLE | SDF_RT | SDF_GROUND | 2855 - SDF_COMMON; 2857 + s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON; 2856 2858 s->n_chan = 1; 2857 2859 s->maxdata = 0; 2858 2860 s->len_chanlist = 1; ··· 2869 2875 if (this_board->i_NbrTTLChannel) { 2870 2876 s->type = COMEDI_SUBD_TTLIO; 2871 2877 s->subdev_flags = 2872 - SDF_WRITEABLE | SDF_READABLE | SDF_RT | 2873 - SDF_GROUND | SDF_COMMON; 2878 + SDF_WRITEABLE | SDF_READABLE | SDF_GROUND | SDF_COMMON; 2874 2879 s->n_chan = this_board->i_NbrTTLChannel; 2875 2880 s->maxdata = 1; 2876 2881 s->io_bits = 0; /* all bits input */
+9 -9
drivers/staging/comedi/drivers/addi-data/hwdrv_APCI1710.c
··· 71 71 s = dev->subdevices + 0; 72 72 73 73 s->type = COMEDI_SUBD_TIMER; 74 - s->subdev_flags = SDF_WRITEABLE | SDF_RT | SDF_GROUND | SDF_COMMON; 74 + s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON; 75 75 s->n_chan = 3; 76 76 s->maxdata = 0; 77 77 s->len_chanlist = 3; ··· 86 86 87 87 s->type = COMEDI_SUBD_DIO; 88 88 s->subdev_flags = 89 - SDF_WRITEABLE | SDF_READABLE | SDF_RT | SDF_GROUND | SDF_COMMON; 89 + SDF_WRITEABLE | SDF_READABLE | SDF_GROUND | SDF_COMMON; 90 90 s->n_chan = 7; 91 91 s->maxdata = 1; 92 92 s->len_chanlist = 7; ··· 100 100 s = dev->subdevices + 2; 101 101 102 102 s->type = COMEDI_SUBD_CHRONO; 103 - s->subdev_flags = SDF_WRITEABLE | SDF_RT | SDF_GROUND | SDF_COMMON; 103 + s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON; 104 104 s->n_chan = 4; 105 105 s->maxdata = 0; 106 106 s->len_chanlist = 4; ··· 114 114 s = dev->subdevices + 3; 115 115 s->type = COMEDI_SUBD_PWM; 116 116 s->subdev_flags = 117 - SDF_WRITEABLE | SDF_READABLE | SDF_RT | SDF_GROUND | SDF_COMMON; 117 + SDF_WRITEABLE | SDF_READABLE | SDF_GROUND | SDF_COMMON; 118 118 s->n_chan = 3; 119 119 s->maxdata = 1; 120 120 s->len_chanlist = 3; ··· 129 129 s = dev->subdevices + 4; 130 130 s->type = COMEDI_SUBD_TTLIO; 131 131 s->subdev_flags = 132 - SDF_WRITEABLE | SDF_READABLE | SDF_RT | SDF_GROUND | SDF_COMMON; 132 + SDF_WRITEABLE | SDF_READABLE | SDF_GROUND | SDF_COMMON; 133 133 s->n_chan = 8; 134 134 s->maxdata = 1; 135 135 s->len_chanlist = 8; ··· 143 143 s = dev->subdevices + 5; 144 144 s->type = COMEDI_SUBD_TOR; 145 145 s->subdev_flags = 146 - SDF_WRITEABLE | SDF_READABLE | SDF_RT | SDF_GROUND | SDF_COMMON; 146 + SDF_WRITEABLE | SDF_READABLE | SDF_GROUND | SDF_COMMON; 147 147 s->n_chan = 8; 148 148 s->maxdata = 1; 149 149 s->len_chanlist = 8; ··· 158 158 s = dev->subdevices + 6; 159 159 s->type = COMEDI_SUBD_SSI; 160 160 s->subdev_flags = 161 - SDF_WRITEABLE | SDF_READABLE | SDF_RT | SDF_GROUND | SDF_COMMON; 161 + SDF_WRITEABLE | SDF_READABLE | SDF_GROUND | SDF_COMMON; 162 162 s->n_chan = 4; 163 163 s->maxdata = 1; 164 164 s->len_chanlist = 4; ··· 171 171 s = dev->subdevices + 7; 172 172 s->type = COMEDI_SUBD_PULSEENCODER; 173 173 s->subdev_flags = 174 - SDF_WRITEABLE | SDF_READABLE | SDF_RT | SDF_GROUND | SDF_COMMON; 174 + SDF_WRITEABLE | SDF_READABLE | SDF_GROUND | SDF_COMMON; 175 175 s->n_chan = 4; 176 176 s->maxdata = 1; 177 177 s->len_chanlist = 4; ··· 185 185 s = dev->subdevices + 8; 186 186 s->type = COMEDI_SUBD_INCREMENTALCOUNTER; 187 187 s->subdev_flags = 188 - SDF_WRITEABLE | SDF_READABLE | SDF_RT | SDF_GROUND | SDF_COMMON; 188 + SDF_WRITEABLE | SDF_READABLE | SDF_GROUND | SDF_COMMON; 189 189 s->n_chan = 500; 190 190 s->maxdata = 1; 191 191 s->len_chanlist = 500;
+1 -1
drivers/staging/comedi/drivers/amplc_pc263.c
··· 307 307 s = dev->subdevices + 0; 308 308 /* digital i/o subdevice */ 309 309 s->type = COMEDI_SUBD_DIO; 310 - s->subdev_flags = SDF_READABLE | SDF_WRITABLE | SDF_RT; 310 + s->subdev_flags = SDF_READABLE | SDF_WRITABLE; 311 311 s->n_chan = 16; 312 312 s->maxdata = 1; 313 313 s->range_table = &range_digital;