Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ACPI: bus: Consolidate all arm specific initialisation into acpi_arm_init()

Move all of the ARM-specific initialization into one function namely
acpi_arm_init(), so it is not necessary to modify/update bus.c every
time a new piece of it is added.

Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Rafael J. Wysocki <rafael@kernel.org>
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
Link: https://lore.kernel.org/r/CAJZ5v0iBZRZmV_oU+VurqxnVMbFN_ttqrL=cLh0sUH+=u0PYsw@mail.gmail.com
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Acked-by: Rafael J. Wysocki <rafael@kernel.org>
Reviewed-by: Shaoqin Huang <shahuang@redhat.com>
Link: https://lore.kernel.org/r/20230606093531.2746732-1-sudeep.holla@arm.com
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

authored by

Sudeep Holla and committed by
Catalin Marinas
fcea0ccf 44c026a7

+30 -43
+1 -1
drivers/acpi/arm64/Makefile
··· 3 3 obj-$(CONFIG_ACPI_IORT) += iort.o 4 4 obj-$(CONFIG_ACPI_GTDT) += gtdt.o 5 5 obj-$(CONFIG_ACPI_APMT) += apmt.o 6 - obj-y += dma.o 6 + obj-y += dma.o init.o
+1 -1
drivers/acpi/arm64/agdi.c
··· 9 9 #define pr_fmt(fmt) "ACPI: AGDI: " fmt 10 10 11 11 #include <linux/acpi.h> 12 - #include <linux/acpi_agdi.h> 13 12 #include <linux/arm_sdei.h> 14 13 #include <linux/io.h> 15 14 #include <linux/kernel.h> 16 15 #include <linux/platform_device.h> 16 + #include "init.h" 17 17 18 18 struct agdi_data { 19 19 int sdei_event;
+1 -1
drivers/acpi/arm64/apmt.c
··· 10 10 #define pr_fmt(fmt) "ACPI: APMT: " fmt 11 11 12 12 #include <linux/acpi.h> 13 - #include <linux/acpi_apmt.h> 14 13 #include <linux/init.h> 15 14 #include <linux/kernel.h> 16 15 #include <linux/platform_device.h> 16 + #include "init.h" 17 17 18 18 #define DEV_NAME "arm-cs-arch-pmu" 19 19
+13
drivers/acpi/arm64/init.c
··· 1 + // SPDX-License-Identifier: GPL-2.0-only 2 + #include <linux/acpi.h> 3 + #include "init.h" 4 + 5 + void __init acpi_arm_init(void) 6 + { 7 + if (IS_ENABLED(CONFIG_ACPI_AGDI)) 8 + acpi_agdi_init(); 9 + if (IS_ENABLED(CONFIG_ACPI_APMT)) 10 + acpi_apmt_init(); 11 + if (IS_ENABLED(CONFIG_ACPI_IORT)) 12 + acpi_iort_init(); 13 + }
+6
drivers/acpi/arm64/init.h
··· 1 + /* SPDX-License-Identifier: GPL-2.0-only */ 2 + #include <linux/init.h> 3 + 4 + void __init acpi_agdi_init(void); 5 + void __init acpi_apmt_init(void); 6 + void __init acpi_iort_init(void);
+1
drivers/acpi/arm64/iort.c
··· 19 19 #include <linux/platform_device.h> 20 20 #include <linux/slab.h> 21 21 #include <linux/dma-map-ops.h> 22 + #include "init.h" 22 23 23 24 #define IORT_TYPE_MASK(type) (1 << (type)) 24 25 #define IORT_MSI_TYPE (1 << ACPI_IORT_NODE_ITS_GROUP)
+1 -6
drivers/acpi/bus.c
··· 26 26 #include <asm/mpspec.h> 27 27 #include <linux/dmi.h> 28 28 #endif 29 - #include <linux/acpi_agdi.h> 30 - #include <linux/acpi_apmt.h> 31 - #include <linux/acpi_iort.h> 32 29 #include <linux/acpi_viot.h> 33 30 #include <linux/pci.h> 34 31 #include <acpi/apei.h> ··· 1405 1408 acpi_init_ffh(); 1406 1409 1407 1410 pci_mmcfg_late_init(); 1408 - acpi_iort_init(); 1411 + acpi_arm_init(); 1409 1412 acpi_viot_early_init(); 1410 1413 acpi_hest_init(); 1411 1414 acpi_ghes_init(); ··· 1417 1420 acpi_debugger_init(); 1418 1421 acpi_setup_sb_notify_handler(); 1419 1422 acpi_viot_init(); 1420 - acpi_agdi_init(); 1421 - acpi_apmt_init(); 1422 1423 return 0; 1423 1424 } 1424 1425
+6
include/linux/acpi.h
··· 1507 1507 } 1508 1508 #endif 1509 1509 1510 + #ifdef CONFIG_ARM64 1511 + void acpi_arm_init(void); 1512 + #else 1513 + static inline void acpi_arm_init(void) { } 1514 + #endif 1515 + 1510 1516 #ifdef CONFIG_ACPI_PCC 1511 1517 void acpi_init_pcc(void); 1512 1518 #else
-13
include/linux/acpi_agdi.h
··· 1 - /* SPDX-License-Identifier: GPL-2.0-only */ 2 - 3 - #ifndef __ACPI_AGDI_H__ 4 - #define __ACPI_AGDI_H__ 5 - 6 - #include <linux/acpi.h> 7 - 8 - #ifdef CONFIG_ACPI_AGDI 9 - void __init acpi_agdi_init(void); 10 - #else 11 - static inline void acpi_agdi_init(void) {} 12 - #endif 13 - #endif /* __ACPI_AGDI_H__ */
-19
include/linux/acpi_apmt.h
··· 1 - /* SPDX-License-Identifier: GPL-2.0 2 - * 3 - * ARM CoreSight PMU driver. 4 - * Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. 5 - * 6 - */ 7 - 8 - #ifndef __ACPI_APMT_H__ 9 - #define __ACPI_APMT_H__ 10 - 11 - #include <linux/acpi.h> 12 - 13 - #ifdef CONFIG_ACPI_APMT 14 - void acpi_apmt_init(void); 15 - #else 16 - static inline void acpi_apmt_init(void) { } 17 - #endif /* CONFIG_ACPI_APMT */ 18 - 19 - #endif /* __ACPI_APMT_H__ */
-2
include/linux/acpi_iort.h
··· 27 27 void iort_deregister_domain_token(int trans_id); 28 28 struct fwnode_handle *iort_find_domain_token(int trans_id); 29 29 #ifdef CONFIG_ACPI_IORT 30 - void acpi_iort_init(void); 31 30 u32 iort_msi_map_id(struct device *dev, u32 id); 32 31 struct irq_domain *iort_get_device_domain(struct device *dev, u32 id, 33 32 enum irq_domain_bus_token bus_token); ··· 42 43 void iort_iommu_get_resv_regions(struct device *dev, struct list_head *head); 43 44 phys_addr_t acpi_iort_dma_get_max_cpu_address(void); 44 45 #else 45 - static inline void acpi_iort_init(void) { } 46 46 static inline u32 iort_msi_map_id(struct device *dev, u32 id) 47 47 { return id; } 48 48 static inline struct irq_domain *iort_get_device_domain(