Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers/ipack/devices/ipoctal.c: adjust duplicate test

Delete successive tests to the same location. The code tested the result
of a previous allocation, that itself was already tested. It is changed to
test the result of the most recent allocation.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@s exists@
local idexpression y;
expression x,e;
@@

*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\)
when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\)
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Julia Lawall and committed by
Greg Kroah-Hartman
fc8d713e 55cd0e36

+1 -1
+1 -1
drivers/ipack/devices/ipoctal.c
··· 289 289 ipoctal->mem8_space = 290 290 devm_ioremap_nocache(&ipoctal->dev->dev, 291 291 region->start, 0x8000); 292 - if (!addr) { 292 + if (!ipoctal->mem8_space) { 293 293 dev_err(&ipoctal->dev->dev, 294 294 "Unable to map slot [%d:%d] MEM8 space!\n", 295 295 bus_nr, slot);