Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

misc: fastrpc: Add meaningful labels for exit paths

In the fastrpc_rpmsg_probe function, the exit path labels are not
intuitive and do not clearly indicate the purpose of the goto
statements. Rename goto labels to make it more intuitive and to
align with labels of other functions.

Signed-off-by: Anandu Krishnan E <quic_anane@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20250310085417.25559-1-quic_anane@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Anandu Krishnan E and committed by
Greg Kroah-Hartman
fc788c40 0af2f6be

+8 -8
+8 -8
drivers/misc/fastrpc.c
··· 2313 2313 rmem = of_reserved_mem_lookup(rmem_node); 2314 2314 if (!rmem) { 2315 2315 err = -EINVAL; 2316 - goto fdev_error; 2316 + goto err_free_data; 2317 2317 } 2318 2318 2319 2319 src_perms = BIT(QCOM_SCM_VMID_HLOS); ··· 2334 2334 data->unsigned_support = false; 2335 2335 err = fastrpc_device_register(rdev, data, secure_dsp, domains[domain_id]); 2336 2336 if (err) 2337 - goto fdev_error; 2337 + goto err_free_data; 2338 2338 break; 2339 2339 case CDSP_DOMAIN_ID: 2340 2340 case CDSP1_DOMAIN_ID: ··· 2342 2342 /* Create both device nodes so that we can allow both Signed and Unsigned PD */ 2343 2343 err = fastrpc_device_register(rdev, data, true, domains[domain_id]); 2344 2344 if (err) 2345 - goto fdev_error; 2345 + goto err_free_data; 2346 2346 2347 2347 err = fastrpc_device_register(rdev, data, false, domains[domain_id]); 2348 2348 if (err) 2349 - goto populate_error; 2349 + goto err_deregister_fdev; 2350 2350 break; 2351 2351 default: 2352 2352 err = -EINVAL; 2353 - goto fdev_error; 2353 + goto err_free_data; 2354 2354 } 2355 2355 2356 2356 kref_init(&data->refcount); ··· 2367 2367 2368 2368 err = of_platform_populate(rdev->of_node, NULL, NULL, rdev); 2369 2369 if (err) 2370 - goto populate_error; 2370 + goto err_deregister_fdev; 2371 2371 2372 2372 return 0; 2373 2373 2374 - populate_error: 2374 + err_deregister_fdev: 2375 2375 if (data->fdevice) 2376 2376 misc_deregister(&data->fdevice->miscdev); 2377 2377 if (data->secure_fdevice) 2378 2378 misc_deregister(&data->secure_fdevice->miscdev); 2379 2379 2380 - fdev_error: 2380 + err_free_data: 2381 2381 kfree(data); 2382 2382 return err; 2383 2383 }