Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests: net: bpf_offload: wait for maps

Maps are removed asynchronously. Either there's a bigger delay
now or the test has always been flaky. Retry waiting in the loop.

Acked-by: Stanislav Fomichev <sdf@google.com>
Acked-by: Martin KaFai Lau <martin.lau@kernel.org>
Link: https://lore.kernel.org/r/20240409031549.3531084-3-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

+8 -8
+8 -8
tools/testing/selftests/net/bpf_offload.py
··· 201 201 time.sleep(0.05) 202 202 raise Exception("Time out waiting for program counts to stabilize want %d, have %d" % (expected, nprogs)) 203 203 204 - def bpftool_map_list_wait(expected=0, n_retry=20): 204 + def bpftool_map_list_wait(expected=0, n_retry=20, ns=""): 205 205 for i in range(n_retry): 206 - nmaps = len(bpftool_map_list()) 207 - if nmaps == expected: 208 - return 206 + maps = bpftool_map_list(ns=ns) 207 + if len(maps) == expected: 208 + return maps 209 209 time.sleep(0.05) 210 210 raise Exception("Time out waiting for map counts to stabilize want %d, have %d" % (expected, nmaps)) 211 211 ··· 605 605 return file_name, bpf_pinned(file_name) 606 606 607 607 def pin_map(file_name, idx=0, expected=1): 608 - maps = bpftool_map_list(expected=expected) 608 + maps = bpftool_map_list_wait(expected=expected) 609 609 m = maps[idx] 610 610 bpftool("map pin id %d %s" % (m["id"], file_name)) 611 611 files.append(file_name) ··· 618 618 ret, err = bpftool("prog show pin %s" % (prog_file), fail=False) 619 619 fail(ret != 0, "failed to show prog with removed device") 620 620 621 - bpftool_map_list(expected=0) 621 + bpftool_map_list_wait(expected=0) 622 622 ret, err = bpftool("map show pin %s" % (map_file), fail=False) 623 623 fail(ret == 0, "Showing map with removed device did not fail") 624 624 fail(err["error"].find("No such device") == -1, ··· 642 642 else: 643 643 fail("ifname" in dev.keys(), "Ifname is reported for other ns") 644 644 645 - maps = bpftool_map_list(expected=2, ns=ns) 645 + maps = bpftool_map_list_wait(expected=2, ns=ns) 646 646 for m in maps: 647 647 fail("dev" not in m.keys(), "Device parameters not reported") 648 648 fail(dev != m["dev"], "Map's device different than program's") ··· 1206 1206 1207 1207 start_test("Test map update (no flags)...") 1208 1208 sim.set_xdp(map_obj, "offload", JSON=False) # map fixup msg breaks JSON 1209 - maps = bpftool_map_list(expected=2) 1209 + maps = bpftool_map_list_wait(expected=2) 1210 1210 array = maps[0] if maps[0]["type"] == "array" else maps[1] 1211 1211 htab = maps[0] if maps[0]["type"] == "hash" else maps[1] 1212 1212 for m in maps: